Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346153002: Remove use of DeviceManager from ChannelManager. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
Nico, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove use of DeviceManager from ChannelManager. BUG=webrtc:4690 Committed: https://crrev.com/facbbecb516547adc2ac684c8e0be95ad79dfd88 Cr-Commit-Position: refs/heads/master@{#10042}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 1

Patch Set 5 : rebase #

Patch Set 6 : fix+rebase #

Patch Set 7 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -565 lines) Patch
M talk/app/webrtc/localaudiosource_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/mediastreamsignaling_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 1 2 3 4 5 3 chunks +1 line, -5 lines 0 comments Download
M talk/app/webrtc/videosource_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/videotrack_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 3 4 5 3 chunks +2 lines, -5 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 2 3 4 5 7 chunks +1 line, -57 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 2 3 4 5 10 chunks +8 lines, -232 lines 1 comment Download
M talk/session/media/channelmanager_unittest.cc View 1 2 3 4 5 6 chunks +2 lines, -251 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
the sun
5 years, 3 months ago (2015-09-16 15:02:09 UTC) #2
pthatcher1
https://codereview.webrtc.org/1346153002/diff/60001/talk/session/media/channelmanager.cc File talk/session/media/channelmanager.cc (left): https://codereview.webrtc.org/1346153002/diff/60001/talk/session/media/channelmanager.cc#oldcode660 talk/session/media/channelmanager.cc:660: VideoCapturer* ChannelManager::CreateVideoCapturer() { This is used still used: https://cs.corp.google.com/#piper///depot/google3/buzz/mediaengines/sdk/talk/harmony/harmony.cc&q=CreateVideoCapturer ...
5 years, 3 months ago (2015-09-23 15:40:21 UTC) #3
pthatcher1
lgtm (Assuming they can use DeviceManager directly).
5 years, 3 months ago (2015-09-23 16:25:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346153002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346153002/120001
5 years, 3 months ago (2015-09-23 21:33:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
5 years, 3 months ago (2015-09-23 23:34:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346153002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346153002/120001
5 years, 3 months ago (2015-09-24 07:40:46 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 3 months ago (2015-09-24 07:41:55 UTC) #12
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/facbbecb516547adc2ac684c8e0be95ad79dfd88 Cr-Commit-Position: refs/heads/master@{#10042}
5 years, 3 months ago (2015-09-24 07:42:11 UTC) #13
Nico
https://codereview.webrtc.org/1346153002/diff/120001/talk/session/media/channelmanager.cc File talk/session/media/channelmanager.cc (right): https://codereview.webrtc.org/1346153002/diff/120001/talk/session/media/channelmanager.cc#newcode641 talk/session/media/channelmanager.cc:641: static void GetDeviceNames(const std::vector<Device>& devs, This function is now ...
5 years, 2 months ago (2015-09-29 07:08:57 UTC) #15
The Sun (google.com)
5 years, 2 months ago (2015-09-29 08:11:22 UTC) #16
Message was sent while issue was closed. 
On 2015/09/29 07:08:57, Nico (offline until Fri Oct 9) wrote:
>
https://codereview.webrtc.org/1346153002/diff/120001/talk/session/media/chann...
> File talk/session/media/channelmanager.cc (right):
> 
>
https://codereview.webrtc.org/1346153002/diff/120001/talk/session/media/chann...
> talk/session/media/channelmanager.cc:641: static void GetDeviceNames(const
> std::vector<Device>& devs,
> This function is now unused. Can you remove this too?

Thanks, that will end up in another CL.

Powered by Google App Engine
This is Rietveld 408576698