Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1345983009: Revert of Tool to convert RtcEventLog files to RtpDump format. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Tool to convert RtcEventLog files to RtpDump format. (patchset #11 id:200001 of https://codereview.webrtc.org/1297653002/ ) Reason for revert: Breaks Chromium WebRTC FYI bots. Updating projects from gyp files... gyp: /b/build/slave/linux/build/src/third_party/gflags/gflags.gyp not found (cwd: /b/build/slave/linux/build) Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit status 1 in /b/build/slave/linux/build Original issue's description: > Tool to convert RtcEventLog files to RtpDump format. > > This is a small utility that reads RtcEventLog files, and converts the RTP headers within it to RtpDump format. All other types of events are ignored. Three command-line flags are supported, --audio-only, --video-only and --data-only. When one of these flags is supplied, only RTP packets that match the requested type are converted. > > BUG=webrtc:4741 > R=henrik.lundin@webrtc.org, kjellander@webrtc.org, stefan@webrtc.org, terelius@webrtc.org > > Committed: https://crrev.com/35624c2c3686a2ad40daffe073aa78507b0ef88e > Cr-Commit-Position: refs/heads/master@{#9980} TBR=henrik.lundin@webrtc.org,terelius@webrtc.org,stefan@webrtc.org,kjellander@webrtc.org,kjellander@google.com,ivoc@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4741 Committed: https://crrev.com/be4959535a39262e1508cc4223b78b8db677cb94 Cr-Commit-Position: refs/heads/master@{#9987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -218 lines) Patch
M webrtc/test/rtp_file_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
D webrtc/video/rtc_event_log2rtp_dump.cc View 1 chunk +0 lines, -207 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Henrik Grunell WebRTC
Created Revert of Tool to convert RtcEventLog files to RtpDump format.
5 years, 3 months ago (2015-09-18 10:49:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345983009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345983009/1
5 years, 3 months ago (2015-09-18 10:50:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 10:50:11 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:50:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be4959535a39262e1508cc4223b78b8db677cb94
Cr-Commit-Position: refs/heads/master@{#9987}

Powered by Google App Engine
This is Rietveld 408576698