Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1345193002: Temporarily define RTC_DISALLOW_ASSIGN in Chromium constructormagic override. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Temporarily define RTC_DISALLOW_ASSIGN in Chromium constructormagic override. The override will be removed shortly in https://codereview.webrtc.org/1342543004/ This is to make the FYI bots happy meanwhile. BUG=chromium:468375 TBR=tommi@webrtc.org NOTRY=true Committed: https://crrev.com/8dba03d6d7b54080a9f2429ccd0a6638a49e509c Cr-Commit-Position: refs/heads/master@{#9951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/overrides/webrtc/base/constructormagic.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345193002/1
5 years, 3 months ago (2015-09-16 11:44:24 UTC) #3
Henrik Grunell WebRTC
5 years, 3 months ago (2015-09-16 11:44:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 11:45:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8dba03d6d7b54080a9f2429ccd0a6638a49e509c Cr-Commit-Position: refs/heads/master@{#9951}
5 years, 3 months ago (2015-09-16 11:45:37 UTC) #6
tommi
5 years, 3 months ago (2015-09-16 16:40:56 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698