Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: webrtc/modules/audio_device/include/audio_device.h

Issue 1344563002: Improving support for Android Audio Effects in WebRTC (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Improved comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_device/include/audio_device.h
diff --git a/webrtc/modules/audio_device/include/audio_device.h b/webrtc/modules/audio_device/include/audio_device.h
index 1826e0ee006aa21381d0b16bf1148f38e1abba0a..c2c2b8810310861b090fe2109b882c35e6342f79 100644
--- a/webrtc/modules/audio_device/include/audio_device.h
+++ b/webrtc/modules/audio_device/include/audio_device.h
@@ -187,18 +187,14 @@ class AudioDeviceModule : public RefCountedModule {
// Only supported on Android.
// TODO(henrika): Make pure virtual after updating Chromium.
virtual bool BuiltInAECIsAvailable() const { return false; }
+ virtual bool BuiltInAGCIsAvailable() const { return false; }
+ virtual bool BuiltInNSIsAvailable() const { return false; }
- // Enables the built-in AEC. Only supported on Windows and Android.
- //
- // For usage on Windows (requires Core Audio):
- // Must be called before InitRecording(). When enabled:
- // 1. StartPlayout() must be called before StartRecording().
- // 2. StopRecording() should be called before StopPlayout().
- // The reverse order may cause garbage audio to be rendered or the
- // capture side to halt until StopRecording() is called.
+ // Enables the built-in audio effects. Only supported on Android.
// TODO(henrika): Make pure virtual after updating Chromium.
virtual int32_t EnableBuiltInAEC(bool enable) { return -1; }
-
+ virtual int32_t EnableBuiltInAGC(bool enable) { return -1; }
+ virtual int32_t EnableBuiltInNS(bool enable) { return -1; }
// Don't use.
virtual bool BuiltInAECIsEnabled() const { return false; }
« no previous file with comments | « webrtc/modules/audio_device/audio_device_impl.cc ('k') | webrtc/modules/audio_device/include/fake_audio_device.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698