webrtc/modules/audio_device/android/audio_record_jni.h - Issue 1344563002: Improving support for Android Audio Effects in WebRTC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/android/audio_record_jni.h

Issue 1344563002: Improving support for Android Audio Effects in WebRTC (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Improved comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/android/audio_manager_unittest.cc ('k') | webrtc/modules/audio_device/android/audio_record_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/android/audio_record_jni.h

diff --git a/webrtc/modules/audio_device/android/audio_record_jni.h b/webrtc/modules/audio_device/android/audio_record_jni.h

index adf381e2d3075802d70eba21b8dd650655c265b7..efd516425a2fe669b6eee45fc6bc1450cc3b995f 100644

--- a/webrtc/modules/audio_device/android/audio_record_jni.h

+++ b/webrtc/modules/audio_device/android/audio_record_jni.h

@@ -53,6 +53,8 @@ class AudioRecordJni {

bool StartRecording();

bool StopRecording();

bool EnableBuiltInAEC(bool enable);

+ bool EnableBuiltInAGC(bool enable);

+ bool EnableBuiltInNS(bool enable);

private:

rtc::scoped_ptr<GlobalRef> audio_record_;

@@ -60,6 +62,8 @@ class AudioRecordJni {

jmethodID start_recording_;

jmethodID stop_recording_;

jmethodID enable_built_in_aec_;

+ jmethodID enable_built_in_agc_;

+ jmethodID enable_built_in_ns_;

};

explicit AudioRecordJni(AudioManager* audio_manager);

@@ -78,6 +82,8 @@ class AudioRecordJni {

void AttachAudioBuffer(AudioDeviceBuffer* audioBuffer);

int32_t EnableBuiltInAEC(bool enable);

+ int32_t EnableBuiltInAGC(bool enable);

+ int32_t EnableBuiltInNS(bool enable);

private:

// Called from Java side so we can cache the address of the Java-manged