Catching more errors when parsing ICE server URLs.

webrtc/base/stringencode_unittest.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 280 matching lines @@
   ASSERT_STREQ("D", fields.at(0).c_str());
   ASSERT_STREQ("\"A", fields.at(1).c_str());
 
   tokenize("D (A B) C (E F) G", ' ', '(', ')', &fields);
   ASSERT_EQ(5ul, fields.size());
   ASSERT_STREQ("D", fields.at(0).c_str());
   ASSERT_STREQ("A B", fields.at(1).c_str());
   ASSERT_STREQ("E F", fields.at(3).c_str());
 }
 
+TEST(TokenizeTest, TokenizeWithEmptyTokens) {
+  std::vector<std::string> fields;
+  EXPECT_EQ(3ul, tokenize_with_empty_tokens("a.b.c", '.', &fields));
+  EXPECT_EQ("a", fields[0]);
+  EXPECT_EQ("b", fields[1]);
+  EXPECT_EQ("c", fields[2]);
+
+  EXPECT_EQ(3ul, tokenize_with_empty_tokens("..c", '.', &fields));

[tommi, 2015/09/16 21:51:01]

add a test case for source == ""?

[Taylor Brandstetter, 2015/09/24 00:25:05]

Done.

+  EXPECT_TRUE(fields[0].empty());
+  EXPECT_TRUE(fields[1].empty());
+  EXPECT_EQ("c", fields[2]);
+}
+
 TEST(TokenizeFirstTest, NoLeadingSpaces) {
   std::string token;
   std::string rest;
 
   ASSERT_TRUE(tokenize_first("A &*${}", ' ', &token, &rest));
   ASSERT_STREQ("A", token.c_str());
   ASSERT_STREQ("&*${}", rest.c_str());
 
   ASSERT_TRUE(tokenize_first("A B& *${}", ' ', &token, &rest));
   ASSERT_STREQ("A", token.c_str());
@@ skipping 110 matching lines @@
   EXPECT_FALSE(FromString<bool>("false\nfalse"));
 }
 
 TEST(BoolTest, RoundTrip) {
   bool value;
   EXPECT_TRUE(FromString(ToString(true), &value));
   EXPECT_TRUE(value);
   EXPECT_TRUE(FromString(ToString(false), &value));
   EXPECT_FALSE(value);
 }
+
 }  // namespace rtc