Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 1343783006: Simplify BitrateAllocator::AddBitrateObserver. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, mflodman, perkj_webrtc, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplify BitrateAllocator::AddBitrateObserver. Remove start_bitrate_bps which is no longer used and return the current allocated bitrate instead of having it as an out parameter, removing the previous return value which is no longer used. Permits removing bitrate controller usage from ViEEncoder. BUG=webrtc:1695 R=stefan@webrtc.org Committed: https://crrev.com/8e4e8b045523efb4d4d3416cc17ddb3d1705e41d Cr-Commit-Position: refs/heads/master@{#9942}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -126 lines) Patch
M webrtc/modules/bitrate_controller/bitrate_allocator.cc View 7 chunks +18 lines, -38 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_allocator_unittest.cc View 1 5 chunks +32 lines, -34 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_allocator.h View 2 chunks +12 lines, -19 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 4 chunks +5 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pbos-webrtc
PTAL
5 years, 3 months ago (2015-09-15 11:14:28 UTC) #1
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-15 11:20:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343783006/1
5 years, 3 months ago (2015-09-15 11:20:37 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/9661) win_x64_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-15 11:29:23 UTC) #6
pbos-webrtc
fix test
5 years, 3 months ago (2015-09-15 12:35:13 UTC) #7
pbos-webrtc
Committed patchset #2 (id:20001) manually as 8e4e8b045523efb4d4d3416cc17ddb3d1705e41d (presubmit successful).
5 years, 3 months ago (2015-09-15 13:08:18 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 13:08:23 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8e4e8b045523efb4d4d3416cc17ddb3d1705e41d
Cr-Commit-Position: refs/heads/master@{#9942}

Powered by Google App Engine
This is Rietveld 408576698