Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1343163003: Partial revert of r9936. (Closed)

Created:
5 years, 3 months ago by AlexG
Modified:
5 years, 3 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Partial revert of r9936. Need to figure out the best way to initialize native logging system while peer connection factory is not created yet. R=jiayl@webrtc.org Committed: https://crrev.com/2338fec627dd5fa8e0cfe6ebccee2cb87fc4bf38 Cr-Commit-Position: refs/heads/master@{#9947}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
AlexG
5 years, 3 months ago (2015-09-15 22:47:47 UTC) #2
jiayl2
lgtm
5 years, 3 months ago (2015-09-15 22:48:57 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343163003/1
5 years, 3 months ago (2015-09-15 22:50:54 UTC) #5
AlexG
Committed patchset #1 (id:1) manually as 2338fec627dd5fa8e0cfe6ebccee2cb87fc4bf38 (presubmit successful).
5 years, 3 months ago (2015-09-15 23:07:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 23:07:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2338fec627dd5fa8e0cfe6ebccee2cb87fc4bf38
Cr-Commit-Position: refs/heads/master@{#9947}

Powered by Google App Engine
This is Rietveld 408576698