Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1342963002: Do not print C++ line numbers for Java logging. (Closed)

Created:
5 years, 3 months ago by AlexG
Modified:
5 years, 3 months ago
Reviewers:
jiayl2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not print C++ line numbers for Java logging. R=jiayl@webrtc.org Committed: https://crrev.com/ebed24dbfb0002c3f8a2574845c0521db1bc947c Cr-Commit-Position: refs/heads/master@{#9945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webrtc/base/logging.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/logging.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
AlexG
5 years, 3 months ago (2015-09-15 00:04:27 UTC) #2
jiayl2
lgtm
5 years, 3 months ago (2015-09-15 00:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342963002/1
5 years, 3 months ago (2015-09-15 16:33:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/7639)
5 years, 3 months ago (2015-09-15 17:43:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342963002/1
5 years, 3 months ago (2015-09-15 17:48:52 UTC) #9
AlexG
Committed patchset #1 (id:1) manually as ebed24dbfb0002c3f8a2574845c0521db1bc947c (presubmit successful).
5 years, 3 months ago (2015-09-15 18:05:37 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 18:05:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebed24dbfb0002c3f8a2574845c0521db1bc947c
Cr-Commit-Position: refs/heads/master@{#9945}

Powered by Google App Engine
This is Rietveld 408576698