Move AudioDecoderOpus next to AudioEncoderOpus

Move AudioDecoderOpus next to AudioEncoderOpus

All AudioDecoder subclasses have historically lived in NetEq, but they
fit better with the codec they wrap.

BUG=webrtc:4557
R=henrik.lundin@webrtc.org

Committed: https://crrev.com/0b05879cd7be89a68f5e189f6f8c610480694b3a
Cr-Commit-Position: refs/heads/master@{#9944}

[kwiberg-webrtc, 2015-09-15 10:24:01]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[kwiberg-webrtc, 2015-09-15 10:25:45]

☮

[hlundin-webrtc, 2015-09-15 10:30:45]

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc (left):

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc:303: #ifdef
WEBRTC_CODEC_OPUS
Did you just lose this conditional compilation of the code? Or is it conditioned
elsewhere?

[kwiberg-webrtc, 2015-09-15 10:45:07]

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc (left):

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc:303: #ifdef
WEBRTC_CODEC_OPUS
On 2015/09/15 10:30:45, hlundin-webrtc wrote:
> Did you just lose this conditional compilation of the code? Or is it
conditioned
> elsewhere?

The entire file I moved it to is conditioned on include_opus (gyp) or
rtc_include_opus (gn), the same thing that says whether WEBRTC_CODEC_OPUS should
be defined.

However, when I do the same operation for other decoders that won't be the case,
since Opus is the only one that's currently conditionally excluded (see
https://code.google.com/p/webrtc/issues/detail?id=4557). My plan there is to
accept a temporary increase in code that should be but isn't conditionally
excluded; shortly thereafter, the final fix for bug 4557 will set things
straight again, but I'm pretty sure it's easiest to do things in the order I
described.

[hlundin-webrtc, 2015-09-15 10:49:13]

I'm going to assume that the wrapper code is copied verbatim from
audio_decoder_impl.* to audio_decoder_opus.*. 

If that is the case: peace, love and lgtm.

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc (left):

https://codereview.webrtc.org/1342933005/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc:303: #ifdef
WEBRTC_CODEC_OPUS
On 2015/09/15 10:45:07, kwiberg-webrtc wrote:
> On 2015/09/15 10:30:45, hlundin-webrtc wrote:
> > Did you just lose this conditional compilation of the code? Or is it
> conditioned
> > elsewhere?
> 
> The entire file I moved it to is conditioned on include_opus (gyp) or
> rtc_include_opus (gn), the same thing that says whether WEBRTC_CODEC_OPUS
should
> be defined.
> 
> However, when I do the same operation for other decoders that won't be the
case,
> since Opus is the only one that's currently conditionally excluded (see
> https://code.google.com/p/webrtc/issues/detail?id=4557). My plan there is to
> accept a temporary increase in code that should be but isn't conditionally
> excluded; shortly thereafter, the final fix for bug 4557 will set things
> straight again, but I'm pretty sure it's easiest to do things in the order I
> described.

Acknowledged.

[kwiberg-webrtc, 2015-09-15 14:06:45]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2015-09-15 14:06:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1342933005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1342933005/1

[commit-bot: I haz the power, 2015-09-15 14:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-15 14:08:42]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/757)

[kwiberg-webrtc, 2015-09-15 15:28:37]

Committed patchset #1 (id:1) manually as
0b05879cd7be89a68f5e189f6f8c610480694b3a (presubmit successful).

[commit-bot: I haz the power, 2015-09-15 15:28:39]

Patchset 1 (id:??) landed as
https://crrev.com/0b05879cd7be89a68f5e189f6f8c610480694b3a
Cr-Commit-Position: refs/heads/master@{#9944}