Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1341943003: Remove default ViEEncoder encoder instance. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove default ViEEncoder encoder instance. BUG=webrtc:1695 R=stefan@webrtc.org Committed: https://crrev.com/a753177f93872a069353f8674d51ca4898b55cb5 Cr-Commit-Position: refs/heads/master@{#9940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -80 lines) Patch
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 3 chunks +2 lines, -4 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 6 chunks +5 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pbos-webrtc
one two woot woot
5 years, 3 months ago (2015-09-15 10:47:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341943003/1
5 years, 3 months ago (2015-09-15 10:47:48 UTC) #3
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-15 10:52:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341943003/1
5 years, 3 months ago (2015-09-15 10:54:06 UTC) #7
pbos-webrtc
Committed patchset #1 (id:1) manually as a753177f93872a069353f8674d51ca4898b55cb5 (presubmit successful).
5 years, 3 months ago (2015-09-15 11:12:38 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:12:39 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a753177f93872a069353f8674d51ca4898b55cb5
Cr-Commit-Position: refs/heads/master@{#9940}

Powered by Google App Engine
This is Rietveld 408576698