Add unit test for nack bandwidth constraint.

Add unit test for nack bandwidth constraint.

BUG=

Committed: https://crrev.com/38778b046f058565bd4bae266f79c46cde806aa1
Cr-Commit-Position: refs/heads/master@{#10111}

[sprang_webrtc, 2015-09-14 10:57:32]

cleanup

[sprang_webrtc, 2015-09-14 10:58:37]

sprang@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2015-09-17 11:45:33]

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1356:
rtp_sender_->SetTargetBitrate(kNumPackets * kPacketSize * 8);
Comment on that you want 30 1400 bytes packets to be possible to send in a
second, just because the unit of what you pass in is in bits and not bits/s.

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1368: // Resending should
work - brings the bandwidth up to the limit.
This surprises me a bit. You have already used the bandwidth as far as I can
tell, since you sent 30 packets in the loop above. What am I missing?

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1373:
sequence_numbers.clear();
This isn't really necessary, as the result should be the same without it.

[sprang_webrtc, 2015-09-21 11:17:05]

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc (right):

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1356:
rtp_sender_->SetTargetBitrate(kNumPackets * kPacketSize * 8);
On 2015/09/17 11:45:33, stefan-webrtc (holmer) wrote:
> Comment on that you want 30 1400 bytes packets to be possible to send in a
> second, just because the unit of what you pass in is in bits and not bits/s.

Done.

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1368: // Resending should
work - brings the bandwidth up to the limit.
On 2015/09/17 11:45:33, stefan-webrtc (holmer) wrote:
> This surprises me a bit. You have already used the bandwidth as far as I can
> tell, since you sent 30 packets in the loop above. What am I missing?

The nack overhead is compensated for in media_optimization when setting new
rates. So this won't kick in until the next OnNetworkChanged. I'll add a
comment.

https://codereview.webrtc.org/1341743002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc:1373:
sequence_numbers.clear();
On 2015/09/17 11:45:33, stefan-webrtc (holmer) wrote:
> This isn't really necessary, as the result should be the same without it.

Done.

[stefan-webrtc, 2015-09-24 06:58:37]

lgtm

[sprang_webrtc, 2015-09-24 08:06:14]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2015-09-24 08:06:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341743002/40001

[commit-bot: I haz the power, 2015-09-24 08:35:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 08:35:26]

Try jobs failed on following builders:
  linux_msan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/4892)

[sprang_webrtc, 2015-09-29 15:06:53]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2015-09-29 15:07:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341743002/40001

[commit-bot: I haz the power, 2015-09-29 16:48:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-29 16:48:39]

Patchset 3 (id:??) landed as
https://crrev.com/38778b046f058565bd4bae266f79c46cde806aa1
Cr-Commit-Position: refs/heads/master@{#10111}