Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java

Issue 1340923002: Android video capture: Remove duplicated code and fix spelling mistakes (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/java/android/org/webrtc/CameraEnumerationAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
diff --git a/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java b/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
index cc47741f36f47169d8842ec83bb6dfd2984219e7..8e195ac937c9db19f5a9ce658c8bc483bdb1e460 100644
--- a/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
+++ b/talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java
@@ -156,7 +156,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {
return (Camera.getNumberOfCameras() >= 2);
}
- void starCapturerAndRender(String deviceName) throws InterruptedException {
+ void startCapturerAndRender(String deviceName) throws InterruptedException {
PeerConnectionFactory factory = new PeerConnectionFactory();
VideoCapturerAndroid capturer =
VideoCapturerAndroid.create(deviceName, null);
@@ -216,9 +216,9 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {
}
@SmallTest
- public void testCreateNoneExistingCamera() throws Exception {
+ public void testCreateNonExistingCamera() throws Exception {
VideoCapturerAndroid capturer = VideoCapturerAndroid.create(
- "none existing camera", null);
+ "non-existing camera", null);
assertNull(capturer);
}
@@ -227,7 +227,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {
// to a Java video renderer using a "default" capturer.
// It tests both the Java and the C++ layer.
public void testStartVideoCapturer() throws Exception {
- starCapturerAndRender("");
+ startCapturerAndRender("");
}
@SmallTest
@@ -235,7 +235,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {
// to a Java video renderer using the front facing video capturer.
// It tests both the Java and the C++ layer.
public void testStartFrontFacingVideoCapturer() throws Exception {
- starCapturerAndRender(CameraEnumerationAndroid.getNameOfFrontFacingDevice());
+ startCapturerAndRender(CameraEnumerationAndroid.getNameOfFrontFacingDevice());
}
@SmallTest
@@ -246,7 +246,7 @@ public class VideoCapturerAndroidTest extends ActivityTestCase {
if (!HaveTwoCameras()) {
return;
}
- starCapturerAndRender(CameraEnumerationAndroid.getNameOfBackFacingDevice());
+ startCapturerAndRender(CameraEnumerationAndroid.getNameOfBackFacingDevice());
}
@SmallTest
« no previous file with comments | « no previous file | talk/app/webrtc/java/android/org/webrtc/CameraEnumerationAndroid.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698