Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: webrtc/video/receive_statistics_proxy.h

Issue 1340623002: Add stats for average QP per frame for VP8 (for received video streams). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: address comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/receive_statistics_proxy.h
diff --git a/webrtc/video/receive_statistics_proxy.h b/webrtc/video/receive_statistics_proxy.h
index 4f2550ad7e2496b0c87d9037946fd4748c3fe635..045f1d84c694b425afd65cb32a1a9d07bb2e1d6f 100644
--- a/webrtc/video/receive_statistics_proxy.h
+++ b/webrtc/video/receive_statistics_proxy.h
@@ -30,6 +30,7 @@ namespace webrtc {
class Clock;
class ViECodec;
class ViEDecoderObserver;
+struct CodecSpecificInfo;
class ReceiveStatisticsProxy : public VCMReceiveStatisticsCallback,
public RtcpStatisticsCallback,
@@ -52,6 +53,8 @@ class ReceiveStatisticsProxy : public VCMReceiveStatisticsCallback,
int jitter_buffer_ms,
int min_playout_delay_ms,
int render_delay_ms);
+ void Encoded(const EncodedImage& encoded_image,
+ const CodecSpecificInfo* codec_specific_info);
// Overrides VCMReceiveStatisticsCallback.
void OnReceiveRatesUpdated(uint32_t bitRate, uint32_t frameRate) override;
@@ -81,6 +84,9 @@ class ReceiveStatisticsProxy : public VCMReceiveStatisticsCallback,
int sum;
int num_samples;
};
+ struct QpCounters {
+ SampleCounter vp8;
+ };
void UpdateHistograms() EXCLUSIVE_LOCKS_REQUIRED(crit_);
@@ -95,6 +101,7 @@ class ReceiveStatisticsProxy : public VCMReceiveStatisticsCallback,
SampleCounter render_height_counter_ GUARDED_BY(crit_);
SampleCounter decode_time_counter_ GUARDED_BY(crit_);
ReportBlockStats report_block_stats_ GUARDED_BY(crit_);
+ QpCounters qp_counters_; // Only accessed on the decoding thread.
};
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698