webrtc/modules/video_coding/main/source/video_receiver.cc - Issue 1340623002: Add stats for average QP per frame for VP8 (for received video streams).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/video_receiver.cc

Issue 1340623002: Add stats for average QP per frame for VP8 (for received video streams). (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: address comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/java/jni/androidmediaencoder_jni.cc ('K') | « webrtc/modules/video_coding/main/source/video_coding_impl.h ('k') | webrtc/modules/video_coding/utility/include/qp_parser.h » ('j') | webrtc/modules/video_coding/utility/include/qp_parser.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/main/source/video_receiver.cc

diff --git a/webrtc/modules/video_coding/main/source/video_receiver.cc b/webrtc/modules/video_coding/main/source/video_receiver.cc

index 7371f9d33721b69910d2dd2b02ca9ba1fc328ecb..761206f773ec73b75dd8e47278f19bf503b69543 100644

--- a/webrtc/modules/video_coding/main/source/video_receiver.cc

+++ b/webrtc/modules/video_coding/main/source/video_receiver.cc

@@ -302,7 +302,13 @@ int32_t VideoReceiver::Decode(uint16_t maxWaitTimeMs) {

if (pre_decode_image_callback_) {

EncodedImage encoded_image(frame->EncodedImage());

- pre_decode_image_callback_->Encoded(encoded_image, NULL, NULL);

+ int qp = -1;

+ if (qp_parser_.GetQp(frame->Buffer(), frame->Length(),

pbos-webrtc 2015/10/15 11:56:02 Log a warning if this fails imo.

åsapersson 2015/10/16 09:33:59 Added log warnings in vp8_header_parser.cc.

+ frame->CodecSpecific()->codecType, &qp)) {

+ encoded_image.qp_ = qp;

+ }

+ pre_decode_image_callback_->Encoded(

+ encoded_image, frame->CodecSpecific(), NULL);

}

#ifdef DEBUG_DECODER_BIT_STREAM