Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1340573002: Refactor RTPPacketHistory to use a packet struct. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor RTPPacketHistory to use a packet struct. Collects packet information within a struct instead of spreading it out over different vectors. Adds a fixed-size buffer to the stored packet instead of using vectors. BUG= R=stefan@webrtc.org Committed: https://crrev.com/c32d2db69bc94480ecb312268c6e6769d4a1cac6 Cr-Commit-Position: refs/heads/master@{#9926}

Patch Set 1 #

Patch Set 2 : remove max packet size as a parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -126 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 1 2 chunks +12 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.cc View 1 16 chunks +44 lines, -90 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history_unittest.cc View 1 11 chunks +20 lines, -25 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
pbos-webrtc
PTAL woo
5 years, 3 months ago (2015-09-11 13:38:01 UTC) #1
pbos-webrtc
remove max packet size as a parameter
5 years, 3 months ago (2015-09-11 13:49:14 UTC) #2
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-11 13:51:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340573002/20001
5 years, 3 months ago (2015-09-11 13:52:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 15:33:41 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 15:33:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c32d2db69bc94480ecb312268c6e6769d4a1cac6
Cr-Commit-Position: refs/heads/master@{#9926}

Powered by Google App Engine
This is Rietveld 408576698