Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: webrtc/video/rtc_event_log.h

Issue 1340283002: Added support for logging the SSRC corresponding to AudioPlayout events. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/rtc_event_log.h
diff --git a/webrtc/video/rtc_event_log.h b/webrtc/video/rtc_event_log.h
index a58d745ecffe0fb0964a499b110e9ed86eea980e..4cbaac2b986b045db1f289091f0b1c29f08fb966 100644
--- a/webrtc/video/rtc_event_log.h
+++ b/webrtc/video/rtc_event_log.h
@@ -31,9 +31,6 @@ enum class MediaType;
class RtcEventLog {
public:
- // The types of debug events that are currently supported for logging.
- enum class DebugEvent { kLogStart, kLogEnd, kAudioPlayout };
-
virtual ~RtcEventLog() {}
static rtc::scoped_ptr<RtcEventLog> Create();
@@ -67,8 +64,8 @@ class RtcEventLog {
const uint8_t* packet,
size_t length) = 0;
- // Logs a debug event.
- virtual void LogDebugEvent(DebugEvent event_type) = 0;
+ // Log an audio playout event
hlundin-webrtc 2015/09/15 12:30:52 Nit: Logs...
ivoc 2015/09/15 14:55:16 Done.
+ virtual void LogAudioPlayout(uint32_t ssrc) = 0;
terelius 2015/09/15 14:32:29 Since there is no more DebugEvent in the C-interfa
ivoc 2015/09/15 14:55:16 I agree, let's do that in a follow-up CL.
// Reads an RtcEventLog file and returns true when reading was successful.
// The result is stored in the given EventStream object.

Powered by Google App Engine
This is Rietveld 408576698