Android MediaCodecVideoDecoder: Remove redundant useSurface arguments

Android MediaCodecVideoDecoder: Remove redundant useSurface arguments

This CL should not do any functional changes. It removes some redundant arguments and unnecessary error checking.

BUG=webrtc:4993
R=glaznev@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/207370f0a2853cc79fb0e0a18cf96ae5c1748c28

[magjed_webrtc, 2015-09-14 14:10:02]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[magjed_webrtc, 2015-09-14 14:10:11]

Please take a look.

[AlexG, 2015-09-14 17:26:57]

https://codereview.webrtc.org/1338943003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (left):

https://codereview.webrtc.org/1338943003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:94: private
boolean useSurface;
I think it is better to keep this variable - it make code a little more cleaner
for me by always using same boolean variable instead of different conditions
(sharedContext != null, surface != null) in different functions. No need indeed
to pass it in initDecode, but just set it once to sharedContext != null.

[magjed_webrtc, 2015-09-15 12:30:28]

https://codereview.webrtc.org/1338943003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java (left):

https://codereview.webrtc.org/1338943003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/MediaCodecVideoDecoder.java:94: private
boolean useSurface;
On 2015/09/14 17:26:56, AlexG wrote:
> I think it is better to keep this variable - it make code a little more
cleaner
> for me by always using same boolean variable instead of different conditions
> (sharedContext != null, surface != null) in different functions. No need
indeed
> to pass it in initDecode, but just set it once to sharedContext != null.

Done.

[AlexG, 2015-09-15 16:38:47]

lgtm

[commit-bot: I haz the power, 2015-09-16 10:32:39]

Patchset 3 (id:??) landed as
https://crrev.com/207370f0a2853cc79fb0e0a18cf96ae5c1748c28
Cr-Commit-Position: refs/heads/master@{#9950}

[magjed_webrtc, 2015-09-16 10:32:41]

Committed patchset #3 (id:40001) manually as
207370f0a2853cc79fb0e0a18cf96ae5c1748c28 (presubmit successful).