Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1226)

Issue 1338773002: Android focus problem on rear camera. (Closed)

Created:
5 years, 3 months ago by Deyan Chakarov
Modified:
5 years, 2 months ago
Reviewers:
magjed_webrtc, AlexG
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android focus problem on rear camera. On some devices (confirmed Samsung) the focus mode is not configured correctly by default. The fix explicitly set the focus mode to FOCUS_MODE_CONTINUOUS_VIDEO if this mode is supported. BUG=webrtc:4991 Committed: https://crrev.com/0ecf1b2f2141c519d31b23a07f5958e2275ef864 Cr-Commit-Position: refs/heads/master@{#10128}

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
AlexG
https://codereview.webrtc.org/1338773002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1338773002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java#newcode421 talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:421: { Move bracket to previous line. https://codereview.webrtc.org/1338773002/diff/1/webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureAndroid.java File webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureAndroid.java ...
5 years, 3 months ago (2015-09-11 20:24:39 UTC) #2
magjed_webrtc
https://codereview.webrtc.org/1338773002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java File talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java (right): https://codereview.webrtc.org/1338773002/diff/1/talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java#newcode423 talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java:423: Log.d(TAG, "focusMode is set to FOCUS_MODE_CONTINUOUS_VIDEO"); I think this ...
5 years, 3 months ago (2015-09-14 08:54:16 UTC) #3
Deyan Chakarov
Code review notes are fixed
5 years, 2 months ago (2015-09-30 14:36:39 UTC) #6
magjed_webrtc
lgtm
5 years, 2 months ago (2015-09-30 15:16:12 UTC) #7
AlexG
lgtm
5 years, 2 months ago (2015-09-30 16:54:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338773002/20001
5 years, 2 months ago (2015-10-01 06:37:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 07:25:48 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 07:26:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ecf1b2f2141c519d31b23a07f5958e2275ef864
Cr-Commit-Position: refs/heads/master@{#10128}

Powered by Google App Engine
This is Rietveld 408576698