Log to webrtc logging stream from java code.

Log to webrtc logging stream from java code.
Future log messages should all be sent to org.webrtc.Logging as well.

BUG=

Committed: https://crrev.com/66f0da2197974dcc1008f25df2bb4e1d463ad506
Cr-Commit-Position: refs/heads/master@{#9936}

R=glaznev@webrtc.org

Committed: https://crrev.com/5975b3c5be44de32ee28c34ca577474e36259e6e
Cr-Commit-Position: refs/heads/master@{#9957}

[jiayl2, 2015-09-12 00:21:03]

jiayl@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[jiayl2, 2015-09-12 00:21:04]

PTAL

[AlexG, 2015-09-14 18:29:00]

On 2015/09/12 00:21:04, jiayl2 wrote:
> PTAL

This will remove tags from messages - as I understood all Java messages will be
printed with "libjingle" tag (kLibjingle in webrtc/base/logging.c). I think it
may be beneficial to still keep the tag out of messages. May be add an option to
construct LogMessage::LogMessage() with both severity and tag parameters and
then pass tag parameter to LogMessage::OutputToDebug()?

There is also audio Java code in
webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine which may
need similar modifications.

[jiayl2, 2015-09-14 19:52:33]

On 2015/09/14 18:29:00, AlexG wrote:
> On 2015/09/12 00:21:04, jiayl2 wrote:
> > PTAL
> 
> This will remove tags from messages - as I understood all Java messages will
be
> printed with "libjingle" tag (kLibjingle in webrtc/base/logging.c). I think it
> may be beneficial to still keep the tag out of messages. May be add an option
to
> construct LogMessage::LogMessage() with both severity and tag parameters and
> then pass tag parameter to LogMessage::OutputToDebug()?
> 
> There is also audio Java code in
> webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine which may
> need similar modifications.

Done for tag.

I'm planning to do the audio/video change in a separate CL.

[jiayl2, 2015-09-14 19:52:40]

PTAL

[AlexG, 2015-09-14 20:12:33]

https://codereview.webrtc.org/1338033003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/Logging.java (right):

https://codereview.webrtc.org/1338033003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/Logging.java:121: private static String
getStackTraceAsString(Throwable e) {
May be mimic Android implementation here (getStackTraceString() from 
https://android.googlesource.com/platform/frameworks/base/+/534a67c/core/java...
)?

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:117: android_tag_(kLibjingle),
kLibjingle is defined for WEBRTC_ANDROID only - this will probably fail to
compile.
Define kLibjingle for all platforms? Also may be worth to rename android_tag to
just "tag" - in case other platform will use it in future?

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:184: android_tag_ = tag;
Move this to ctor initialization list?

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:400: prio = ANDROID_LOG_INFO;
May be use ANDROID_LOG_DEBUG here? We are mostly using Log.d, but it now will be
routed to Log.i

[jiayl2, 2015-09-14 20:54:38]

PTAL

https://codereview.webrtc.org/1338033003/diff/20001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/Logging.java (right):

https://codereview.webrtc.org/1338033003/diff/20001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/Logging.java:121: private static String
getStackTraceAsString(Throwable e) {
On 2015/09/14 20:12:33, AlexG wrote:
> May be mimic Android implementation here (getStackTraceString() from 
>
https://android.googlesource.com/platform/frameworks/base/+/534a67c/core/java...
> )?
> 

Done.

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:117: android_tag_(kLibjingle),
On 2015/09/14 20:12:33, AlexG wrote:
> kLibjingle is defined for WEBRTC_ANDROID only - this will probably fail to
> compile.
> Define kLibjingle for all platforms? Also may be worth to rename android_tag
to
> just "tag" - in case other platform will use it in future?

Done.

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:184: android_tag_ = tag;
On 2015/09/14 20:12:33, AlexG wrote:
> Move this to ctor initialization list?

That will cause compile error

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:400: prio = ANDROID_LOG_INFO;
On 2015/09/14 20:12:33, AlexG wrote:
> May be use ANDROID_LOG_DEBUG here? We are mostly using Log.d, but it now will
be
> routed to Log.i

Mapping info to info is more intuitive. Unless you have a strong reason to use
log.d, I think it's fine to change to log.i.

[AlexG, 2015-09-14 21:02:11]

lgtm

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
webrtc/base/logging.cc:400: prio = ANDROID_LOG_INFO;
On 2015/09/14 20:54:38, jiayl2 wrote:
> On 2015/09/14 20:12:33, AlexG wrote:
> > May be use ANDROID_LOG_DEBUG here? We are mostly using Log.d, but it now
will
> be
> > routed to Log.i
> 
> Mapping info to info is more intuitive. Unless you have a strong reason to use
> log.d, I think it's fine to change to log.i.

I meant all Lod.d call from Java will now actually become Log.i:
 public static void d(String tag, String message) {
   log(Severity.LS_INFO, tag, message);
 }

But it may be ok

https://codereview.webrtc.org/1338033003/diff/40001/talk/app/webrtc/java/src/...
File talk/app/webrtc/java/src/org/webrtc/Logging.java (right):

https://codereview.webrtc.org/1338033003/diff/40001/talk/app/webrtc/java/src/...
talk/app/webrtc/java/src/org/webrtc/Logging.java:122: StringWriter sw = new
StringWriter();
Add 

if (tr == null) {
 return "";
}

to be safe

[jiayl2, 2015-09-14 21:05:29]

On 2015/09/14 21:02:11, AlexG wrote:
> lgtm
> 
> https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc
> File webrtc/base/logging.cc (right):
> 
>
https://codereview.webrtc.org/1338033003/diff/20001/webrtc/base/logging.cc#ne...
> webrtc/base/logging.cc:400: prio = ANDROID_LOG_INFO;
> On 2015/09/14 20:54:38, jiayl2 wrote:
> > On 2015/09/14 20:12:33, AlexG wrote:
> > > May be use ANDROID_LOG_DEBUG here? We are mostly using Log.d, but it now
> will
> > be
> > > routed to Log.i
> > 
> > Mapping info to info is more intuitive. Unless you have a strong reason to
use
> > log.d, I think it's fine to change to log.i.
> 
> I meant all Lod.d call from Java will now actually become Log.i:
>  public static void d(String tag, String message) {
>    log(Severity.LS_INFO, tag, message);
>  }
> 
> But it may be ok
> 
ack.

>
https://codereview.webrtc.org/1338033003/diff/40001/talk/app/webrtc/java/src/...
> File talk/app/webrtc/java/src/org/webrtc/Logging.java (right):
> 
>
https://codereview.webrtc.org/1338033003/diff/40001/talk/app/webrtc/java/src/...
> talk/app/webrtc/java/src/org/webrtc/Logging.java:122: StringWriter sw = new
> StringWriter();
> Add 
> 
> if (tr == null) {
>  return "";
> }
> 
> to be safe

done.

[jiayl2, 2015-09-14 21:17:18]

The CQ bit was checked by jiayl@webrtc.org

[jiayl2, 2015-09-14 21:17:18]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1338033003/#ps80001 (title:
"sync")

[commit-bot: I haz the power, 2015-09-14 21:17:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338033003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338033003/80001

[commit-bot: I haz the power, 2015-09-14 22:06:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-14 22:06:54]

Patchset 5 (id:??) landed as
https://crrev.com/66f0da2197974dcc1008f25df2bb4e1d463ad506
Cr-Commit-Position: refs/heads/master@{#9936}

[jiayl2, 2015-09-16 19:13:30]

The CQ bit was checked by jiayl@webrtc.org

[jiayl2, 2015-09-16 19:13:30]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1338033003/#ps100001 (title:
" ")

[commit-bot: I haz the power, 2015-09-16 19:13:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338033003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338033003/100001

[commit-bot: I haz the power, 2015-09-16 19:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-16 19:38:32]

Try jobs failed on following builders:
  android_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/5672)

[jiayl2, 2015-09-16 19:49:34]

The CQ bit was checked by jiayl@webrtc.org

[commit-bot: I haz the power, 2015-09-16 19:49:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1338033003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1338033003/100001

[jiayl2, 2015-09-16 20:41:08]

Committed patchset #6 (id:100001) manually as
5975b3c5be44de32ee28c34ca577474e36259e6e (presubmit successful).

[commit-bot: I haz the power, 2015-09-16 20:41:12]

Patchset 6 (id:??) landed as
https://crrev.com/5975b3c5be44de32ee28c34ca577474e36259e6e
Cr-Commit-Position: refs/heads/master@{#9957}