talk/app/webrtc/peerconnectioninterface.h - Issue 1337673002: Change WebRTC SslCipher to be exposed as number only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/app/webrtc/peerconnectioninterface.h

diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h

index ca853385e6327fdcad52014b32abc115685e80c1..6aa1f2256016ce40296fdddb52e64d3f6575e3d7 100644

--- a/talk/app/webrtc/peerconnectioninterface.h

+++ b/talk/app/webrtc/peerconnectioninterface.h

@@ -137,9 +137,6 @@ class MetricsObserverInterface : public rtc::RefCountInterface {

virtual void AddHistogramSample(PeerConnectionMetricsName type,

int value) = 0;

- // TODO(jbauch): Make method abstract when it is implemented by Chromium.

- virtual void AddHistogramSample(PeerConnectionMetricsName type,

- const std::string& value) {}

protected:

virtual ~MetricsObserverInterface() {}

« talk/app/webrtc/peerconnection_unittest.cc ('K') | « talk/app/webrtc/peerconnection_unittest.cc ('k') | talk/app/webrtc/umametrics.h » ('j') | talk/app/webrtc/webrtcsession.cc » ('J')