Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: talk/app/webrtc/fakemetricsobserver.cc

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/fakemetricsobserver.cc
diff --git a/talk/app/webrtc/fakemetricsobserver.cc b/talk/app/webrtc/fakemetricsobserver.cc
index c27531144e9244ac0d6260bc6fc4b1f9a7967a19..407ad00ecd25c808d123072a3821fe7159b9502d 100644
--- a/talk/app/webrtc/fakemetricsobserver.cc
+++ b/talk/app/webrtc/fakemetricsobserver.cc
@@ -37,10 +37,7 @@ FakeMetricsObserver::FakeMetricsObserver() {
void FakeMetricsObserver::Reset() {
DCHECK(thread_checker_.CalledOnValidThread());
counters_.clear();
- memset(int_histogram_samples_, 0, sizeof(int_histogram_samples_));
- for (std::string& type : string_histogram_samples_) {
- type.clear();
- }
+ memset(histogram_samples_, 0, sizeof(histogram_samples_));
}
void FakeMetricsObserver::IncrementEnumCounter(
@@ -61,14 +58,8 @@ void FakeMetricsObserver::IncrementEnumCounter(
void FakeMetricsObserver::AddHistogramSample(PeerConnectionMetricsName type,
int value) {
DCHECK(thread_checker_.CalledOnValidThread());
- DCHECK_EQ(int_histogram_samples_[type], 0);
- int_histogram_samples_[type] = value;
-}
-
-void FakeMetricsObserver::AddHistogramSample(PeerConnectionMetricsName type,
- const std::string& value) {
- DCHECK(thread_checker_.CalledOnValidThread());
- string_histogram_samples_[type].assign(value);
+ DCHECK_EQ(histogram_samples_[type], 0);
+ histogram_samples_[type] = value;
}
int FakeMetricsObserver::GetEnumCounter(PeerConnectionEnumCounterType type,
@@ -79,16 +70,10 @@ int FakeMetricsObserver::GetEnumCounter(PeerConnectionEnumCounterType type,
return counters_[type][counter];
}
-int FakeMetricsObserver::GetIntHistogramSample(
- PeerConnectionMetricsName type) const {
- DCHECK(thread_checker_.CalledOnValidThread());
- return int_histogram_samples_[type];
-}
-
-const std::string& FakeMetricsObserver::GetStringHistogramSample(
+int FakeMetricsObserver::GetHistogramSample(
PeerConnectionMetricsName type) const {
DCHECK(thread_checker_.CalledOnValidThread());
- return string_histogram_samples_[type];
+ return histogram_samples_[type];
}
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698