Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: talk/app/webrtc/statscollector_unittest.cc

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/statscollector.cc ('k') | talk/app/webrtc/umametrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/statscollector_unittest.cc
diff --git a/talk/app/webrtc/statscollector_unittest.cc b/talk/app/webrtc/statscollector_unittest.cc
index 7c055f6566862c7f8af5dc77df1a12df7d0f1c4f..5e658680be50f965cb46e9135efb3de2ba1dc9d5 100644
--- a/talk/app/webrtc/statscollector_unittest.cc
+++ b/talk/app/webrtc/statscollector_unittest.cc
@@ -59,6 +59,11 @@ using webrtc::PeerConnectionInterface;
using webrtc::StatsReport;
using webrtc::StatsReports;
+namespace {
+// This value comes from openssl/tls1.h
+const uint16_t TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA = 0xC014;
+} // namespace
+
namespace cricket {
class ChannelManager;
@@ -647,7 +652,7 @@ class StatsCollectorTest : public testing::Test {
cricket::TransportChannelStats channel_stats;
channel_stats.component = 1;
channel_stats.srtp_cipher = "the-srtp-cipher";
- channel_stats.ssl_cipher = "the-ssl-cipher";
+ channel_stats.ssl_cipher = TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA;
cricket::TransportStats transport_stats;
transport_stats.transport_name = "audio";
@@ -716,7 +721,9 @@ class StatsCollectorTest : public testing::Test {
StatsReport::kStatsReportTypeComponent,
reports,
StatsReport::kStatsValueNameDtlsCipher);
- EXPECT_EQ("the-ssl-cipher", dtls_cipher);
+ EXPECT_EQ(rtc::SSLStreamAdapter::GetSslCipherSuiteName(
+ TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA),
+ dtls_cipher);
std::string srtp_cipher = ExtractStatsValue(
StatsReport::kStatsReportTypeComponent,
reports,
« no previous file with comments | « talk/app/webrtc/statscollector.cc ('k') | talk/app/webrtc/umametrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698