Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: talk/app/webrtc/fakemetricsobserver.h

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/fakemetricsobserver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/fakemetricsobserver.h
diff --git a/talk/app/webrtc/fakemetricsobserver.h b/talk/app/webrtc/fakemetricsobserver.h
index 39454bf4db48862a32b0b7d7b64ed6a1bc184502..e3a22841d84c2104dafcdee1b5e9a18cc46e9591 100644
--- a/talk/app/webrtc/fakemetricsobserver.h
+++ b/talk/app/webrtc/fakemetricsobserver.h
@@ -46,25 +46,21 @@ class FakeMetricsObserver : public MetricsObserverInterface {
int counter_max) override;
void AddHistogramSample(PeerConnectionMetricsName type,
int value) override;
- void AddHistogramSample(PeerConnectionMetricsName type,
- const std::string& value) override;
// Accessors to be used by the tests.
int GetEnumCounter(PeerConnectionEnumCounterType type, int counter) const;
- int GetIntHistogramSample(PeerConnectionMetricsName type) const;
- const std::string& GetStringHistogramSample(
- PeerConnectionMetricsName type) const;
+ int GetHistogramSample(PeerConnectionMetricsName type) const;
protected:
~FakeMetricsObserver() {}
private:
rtc::ThreadChecker thread_checker_;
- // This is a 2 dimension array. The first index is the enum counter type. The
- // 2nd index is the counter of that particular enum counter type.
- std::vector<std::vector<int>> counters_;
- int int_histogram_samples_[kPeerConnectionMetricsName_Max];
- std::string string_histogram_samples_[kPeerConnectionMetricsName_Max];
+ // The vector contains maps for each counter type. In the map, it's a mapping
+ // from individual counter to its count, such that it's memory efficient when
+ // comes to sparse enum types, like the SSL ciphers in the IANA registry.
+ std::vector<std::map<int, int>> counters_;
+ int histogram_samples_[kPeerConnectionMetricsName_Max];
};
} // namespace webrtc
« no previous file with comments | « no previous file | talk/app/webrtc/fakemetricsobserver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698