Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: talk/app/webrtc/webrtcsession.cc

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsession.cc
diff --git a/talk/app/webrtc/webrtcsession.cc b/talk/app/webrtc/webrtcsession.cc
index bd1cd1a0ac8589af2b76977748e3ce7e6af25308..f30076e5b9bea34d6f7a57315f3cb1a0713a6793 100644
--- a/talk/app/webrtc/webrtcsession.cc
+++ b/talk/app/webrtc/webrtcsession.cc
@@ -2141,32 +2141,33 @@ void WebRtcSession::ReportNegotiatedCiphers(
}
const std::string& srtp_cipher = stats.channel_stats[0].srtp_cipher;
- const std::string& ssl_cipher = stats.channel_stats[0].ssl_cipher;
- if (srtp_cipher.empty() && ssl_cipher.empty()) {
+ uint16_t ssl_cipher = stats.channel_stats[0].ssl_cipher;
+ if (srtp_cipher.empty() && !ssl_cipher) {
return;
}
- PeerConnectionMetricsName srtp_name;
- PeerConnectionMetricsName ssl_name;
+ PeerConnectionEnumCounterType srtp_counter_type;
+ PeerConnectionEnumCounterType ssl_counter_type;
if (stats.transport_name == cricket::CN_AUDIO) {
- srtp_name = kAudioSrtpCipher;
- ssl_name = kAudioSslCipher;
+ srtp_counter_type = kEnumCounterAudioSrtpCipher;
+ ssl_counter_type = kEnumCounterAudioSslCipher;
} else if (stats.transport_name == cricket::CN_VIDEO) {
- srtp_name = kVideoSrtpCipher;
- ssl_name = kVideoSslCipher;
+ srtp_counter_type = kEnumCounterVideoSrtpCipher;
+ ssl_counter_type = kEnumCounterVideoSslCipher;
} else if (stats.transport_name == cricket::CN_DATA) {
- srtp_name = kDataSrtpCipher;
- ssl_name = kDataSslCipher;
+ srtp_counter_type = kEnumCounterDataSrtpCipher;
+ ssl_counter_type = kEnumCounterDataSslCipher;
} else {
RTC_NOTREACHED();
return;
}
if (!srtp_cipher.empty()) {
- metrics_observer_->AddHistogramSample(srtp_name, srtp_cipher);
+ metrics_observer_->IncrementSparseEnumCounter(
+ srtp_counter_type, rtc::GetSrtpCipherType(srtp_cipher));
}
- if (!ssl_cipher.empty()) {
- metrics_observer_->AddHistogramSample(ssl_name, ssl_cipher);
+ if (!ssl_cipher) {
+ metrics_observer_->IncrementSparseEnumCounter(ssl_counter_type, ssl_cipher);
}
}

Powered by Google App Engine
This is Rietveld 408576698