talk/app/webrtc/statscollector.cc - Issue 1337673002: Change WebRTC SslCipher to be exposed as number only.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/statscollector.cc

Issue 1337673002: Change WebRTC SslCipher to be exposed as number only. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/peerconnectioninterface.h ('K') | « talk/app/webrtc/peerconnectioninterface.h ('k') | talk/app/webrtc/statscollector_unittest.cc » ('j') | webrtc/base/opensslstreamadapter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/statscollector.cc

diff --git a/talk/app/webrtc/statscollector.cc b/talk/app/webrtc/statscollector.cc

index 021234709dc2983af631f81db01df8db4ac18de5..cfae31f00ca62d3b0c53b5e2fcfd01282c58ce6b 100644

--- a/talk/app/webrtc/statscollector.cc

+++ b/talk/app/webrtc/statscollector.cc

@@ -734,10 +734,11 @@ void StatsCollector::ExtractSessionInfo() {

channel_report->AddString(StatsReport::kStatsValueNameSrtpCipher,

srtp_cipher);

}

- const std::string& ssl_cipher = channel_iter.ssl_cipher;

- if (!ssl_cipher.empty()) {

- channel_report->AddString(StatsReport::kStatsValueNameDtlsCipher,

- ssl_cipher);

+ uint16_t ssl_cipher = channel_iter.ssl_cipher;

+ if (ssl_cipher != 0) {

+ channel_report->AddString(

+ StatsReport::kStatsValueNameDtlsCipher,

+ rtc::SSLStreamAdapter::GetRfcSslCipherName(ssl_cipher));

}

int connection_id = 0;