Change WebRTC SslCipher to be exposed as number only.

webrtc/p2p/base/p2ptransportchannel.h

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 93 matching lines @@
   bool GetSslRole(rtc::SSLRole* role) const override { return false; }
 
   bool SetSslRole(rtc::SSLRole role) override { return false; }
 
   // Set up the ciphers to use for DTLS-SRTP.
   bool SetSrtpCiphers(const std::vector<std::string>& ciphers) override {
     return false;
   }
 
   // Find out which DTLS-SRTP cipher was negotiated.
   bool GetSrtpCipher(std::string* cipher) override { return false; }

[pthatcher1, 2015/09/29 22:25:17]

If we're going to change the SslCipher to an int rather than a string, we should
probably do the same for SrtpCipher.

If it's not critical for the DTLS 1.2 work you're trying to land, can you put a
TODO and then have a follow-up CL after you land this one?

[guoweis_webrtc, 2015/09/30 04:09:47]

Changing srtp is probably more work. GetSrtpCipher is used in for example
talk/session/media/channel.h as string already.

BoringSSL defines these integers already so it's easy for us to reuse instead of
redefining our own. I don't know if it's the case for SRTP. I could be wrong but
I don't think it's the case. It's just where we want the integer version
ourselves internally. I agree this is more consistent but not sure how much it
buys for us.

 
   // Find out which DTLS cipher was negotiated.
-  bool GetSslCipher(std::string* cipher) override { return false; }
+  bool GetSslCipher(uint16_t* cipher) override { return false; }
 
   // Returns null because the channel is not encrypted by default.
   rtc::scoped_refptr<rtc::RTCCertificate> GetLocalCertificate() const override {
     return nullptr;
   }
 
   bool GetRemoteSSLCertificate(rtc::SSLCertificate** cert) const override {
     return false;
   }
 
@@ skipping 120 matching lines @@
 
   int check_receiving_delay_;
   int receiving_timeout_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(P2PTransportChannel);
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_P2PTRANSPORTCHANNEL_H_