Change WebRTC SslCipher to be exposed as number only.

webrtc/base/sslstreamadapter_unittest.cc

 /*
  *  Copyright 2011 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 392 matching lines @@
       return server_ssl_->GetDtlsSrtpCipher(retval);
   }
 
   bool GetPeerCertificate(bool client, rtc::SSLCertificate** cert) {
     if (client)
       return client_ssl_->GetPeerCertificate(cert);
     else
       return server_ssl_->GetPeerCertificate(cert);
   }
 
-  bool GetSslCipher(bool client, std::string *retval) {
+  bool GetSslCipher(bool client, uint16_t* retval) {
+    uint16_t cipher;
+    bool ret;
     if (client)
-      return client_ssl_->GetSslCipher(retval);
+      ret = client_ssl_->GetSslCipher(&cipher);
     else
-      return server_ssl_->GetSslCipher(retval);
+      ret = server_ssl_->GetSslCipher(&cipher);
+
+    if (ret)
+      *retval = cipher;
+    return ret;

[davidben_webrtc, 2015/09/25 19:23:13]

Nit: Any reason not to just write this as:

  if (client)
    return client_ssl_->GetSslCipher(retval);
  else
    return server_ssl_->GetSslCipher(retval);

   }
 
   bool ExportKeyingMaterial(const char *label,
                             const unsigned char *context,
                             size_t context_len,
                             bool use_context,
                             bool client,
                             unsigned char *result,
                             size_t result_len) {
     if (client)
@@ skipping 537 matching lines @@
   ASSERT_FALSE(server_peer_cert->GetChain(&server_peer_chain));
 }
 
 // Test getting the used DTLS ciphers.
 // DTLS 1.2 enabled for neither client nor server -> DTLS 1.0 will be used.
 TEST_P(SSLStreamAdapterTestDTLS, TestGetSslCipher) {
   MAYBE_SKIP_TEST(HaveDtls);
   SetupProtocolVersions(rtc::SSL_PROTOCOL_DTLS_10, rtc::SSL_PROTOCOL_DTLS_10);
   TestHandshake();
 
-  std::string client_cipher;
+  uint16_t client_cipher;
   ASSERT_TRUE(GetSslCipher(true, &client_cipher));
-  std::string server_cipher;
+  uint16_t server_cipher;
   ASSERT_TRUE(GetSslCipher(false, &server_cipher));
 
   ASSERT_EQ(client_cipher, server_cipher);
-  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipher(
+  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipherForTest(
                 rtc::SSL_PROTOCOL_DTLS_10, ::testing::get<1>(GetParam())),
             server_cipher);
 }
 
 // Test getting the used DTLS 1.2 ciphers.
 // DTLS 1.2 enabled for client and server -> DTLS 1.2 will be used.
 TEST_P(SSLStreamAdapterTestDTLS, TestGetSslCipherDtls12Both) {
   MAYBE_SKIP_TEST(HaveDtls);
   SetupProtocolVersions(rtc::SSL_PROTOCOL_DTLS_12, rtc::SSL_PROTOCOL_DTLS_12);
   TestHandshake();
 
-  std::string client_cipher;
+  uint16_t client_cipher;
   ASSERT_TRUE(GetSslCipher(true, &client_cipher));
-  std::string server_cipher;
+  uint16_t server_cipher;
   ASSERT_TRUE(GetSslCipher(false, &server_cipher));
 
   ASSERT_EQ(client_cipher, server_cipher);
-  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipher(
+  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipherForTest(
                 rtc::SSL_PROTOCOL_DTLS_12, ::testing::get<1>(GetParam())),
             server_cipher);
 }
 
 // DTLS 1.2 enabled for client only -> DTLS 1.0 will be used.
 TEST_P(SSLStreamAdapterTestDTLS, TestGetSslCipherDtls12Client) {
   MAYBE_SKIP_TEST(HaveDtls);
   SetupProtocolVersions(rtc::SSL_PROTOCOL_DTLS_10, rtc::SSL_PROTOCOL_DTLS_12);
   TestHandshake();
 
-  std::string client_cipher;
+  uint16_t client_cipher;
   ASSERT_TRUE(GetSslCipher(true, &client_cipher));
-  std::string server_cipher;
+  uint16_t server_cipher;
   ASSERT_TRUE(GetSslCipher(false, &server_cipher));
 
   ASSERT_EQ(client_cipher, server_cipher);
-  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipher(
+  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipherForTest(
                 rtc::SSL_PROTOCOL_DTLS_10, ::testing::get<1>(GetParam())),
             server_cipher);
 }
 
 // DTLS 1.2 enabled for server only -> DTLS 1.0 will be used.
 TEST_P(SSLStreamAdapterTestDTLS, TestGetSslCipherDtls12Server) {
   MAYBE_SKIP_TEST(HaveDtls);
   SetupProtocolVersions(rtc::SSL_PROTOCOL_DTLS_12, rtc::SSL_PROTOCOL_DTLS_10);
   TestHandshake();
 
-  std::string client_cipher;
+  uint16_t client_cipher;
   ASSERT_TRUE(GetSslCipher(true, &client_cipher));
-  std::string server_cipher;
+  uint16_t server_cipher;
   ASSERT_TRUE(GetSslCipher(false, &server_cipher));
 
   ASSERT_EQ(client_cipher, server_cipher);
-  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipher(
+  ASSERT_EQ(rtc::SSLStreamAdapter::GetDefaultSslCipherForTest(
                 rtc::SSL_PROTOCOL_DTLS_10, ::testing::get<1>(GetParam())),
             server_cipher);
 }
 
 INSTANTIATE_TEST_CASE_P(SSLStreamAdapterTestsTLS,
                         SSLStreamAdapterTestTLS,
                         Combine(Values(rtc::KT_RSA, rtc::KT_ECDSA),
                                 Values(rtc::KT_RSA, rtc::KT_ECDSA)));
 INSTANTIATE_TEST_CASE_P(SSLStreamAdapterTestsDTLS,
                         SSLStreamAdapterTestDTLS,
                         Combine(Values(rtc::KT_RSA, rtc::KT_ECDSA),
                                 Values(rtc::KT_RSA, rtc::KT_ECDSA)));