Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1336553003: Revert change which removes GICE (Closed)

Created:
5 years, 3 months ago by guoweis_webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert change which removes GICE. There are still dependencies on this functionality. TBR=pthatcher@webrtc.org BUG=526399 Committed: https://crrev.com/d12140a68efdcffa1c2c18f25149905e9dae1a9c Cr-Commit-Position: refs/heads/master@{#9920}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1776 lines, -473 lines) Patch
M talk/app/webrtc/jsepsessiondescription_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 4 chunks +53 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsdp.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 8 chunks +17 lines, -7 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 10 chunks +73 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +19 lines, -0 lines 0 comments Download
M talk/session/media/mediasession.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M webrtc/p2p/base/candidate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/constants.h View 2 chunks +14 lines, -0 lines 0 comments Download
M webrtc/p2p/base/constants.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 7 chunks +34 lines, -2 lines 0 comments Download
M webrtc/p2p/base/fakesession.h View 5 chunks +9 lines, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 15 chunks +162 lines, -73 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 32 chunks +268 lines, -148 lines 0 comments Download
M webrtc/p2p/base/port.h View 4 chunks +22 lines, -1 line 0 comments Download
M webrtc/p2p/base/port.cc View 24 chunks +207 lines, -69 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 31 chunks +372 lines, -68 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/session.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/session.cc View 4 chunks +8 lines, -1 line 0 comments Download
M webrtc/p2p/base/transport.h View 7 chunks +11 lines, -1 line 0 comments Download
M webrtc/p2p/base/transport.cc View 8 chunks +84 lines, -1 line 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 12 chunks +27 lines, -15 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 2 chunks +3 lines, -9 lines 0 comments Download
M webrtc/p2p/base/transportdescription.h View 4 chunks +22 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 4 chunks +38 lines, -5 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 8 chunks +132 lines, -23 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 4 chunks +14 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 1 19 chunks +48 lines, -4 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336553003/40001
5 years, 3 months ago (2015-09-10 20:21:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336553003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336553003/40001
5 years, 3 months ago (2015-09-10 20:31:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-10 20:32:17 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 20:32:30 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d12140a68efdcffa1c2c18f25149905e9dae1a9c
Cr-Commit-Position: refs/heads/master@{#9920}

Powered by Google App Engine
This is Rietveld 408576698