Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1336023004: Keep lock after updating encoder parameters. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Keep lock after updating encoder parameters. Additionally adds some thread annotations. BUG= R=stefan@webrtc.org Committed: https://crrev.com/dcb89988216916aebd479aec20798868ea093716 Cr-Commit-Position: refs/heads/master@{#9941}

Patch Set 1 #

Patch Set 2 : void -> Set.. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -47 lines) Patch
M webrtc/modules/video_coding/main/source/video_coding_impl.h View 1 3 chunks +17 lines, -13 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 1 13 chunks +24 lines, -34 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pbos-webrtc
hola~
5 years, 3 months ago (2015-09-15 09:37:14 UTC) #1
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-15 09:41:48 UTC) #2
pbos-webrtc
void -> Set..
5 years, 3 months ago (2015-09-15 09:50:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336023004/20001
5 years, 3 months ago (2015-09-15 09:50:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
5 years, 3 months ago (2015-09-15 11:50:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1336023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1336023004/20001
5 years, 3 months ago (2015-09-15 12:23:58 UTC) #10
pbos-webrtc
Committed patchset #2 (id:20001) manually as dcb89988216916aebd479aec20798868ea093716 (presubmit successful).
5 years, 3 months ago (2015-09-15 12:44:02 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 12:44:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcb89988216916aebd479aec20798868ea093716
Cr-Commit-Position: refs/heads/master@{#9941}

Powered by Google App Engine
This is Rietveld 408576698