webrtc/system_wrappers/source/tick_util.cc - Issue 1335923002: Add RTC_ prefix to (D)CHECKs and related macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/tick_util.cc

Issue 1335923002: Add RTC_ prefix to (D)CHECKs and related macros. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/system_wrappers/source/tick_util.cc

diff --git a/webrtc/system_wrappers/source/tick_util.cc b/webrtc/system_wrappers/source/tick_util.cc

index 8895b9172d1d53814f47748d561bf73760997b76..9602ab2e092dc49be0894f1c91edbbd346254597 100644

--- a/webrtc/system_wrappers/source/tick_util.cc

+++ b/webrtc/system_wrappers/source/tick_util.cc

@@ -75,8 +75,8 @@ int64_t TickTime::QueryOsForTicks() {

// Recommended by Apple's QA1398.

kern_return_t retval = mach_timebase_info(&timebase);

if (retval != KERN_SUCCESS) {

- // TODO(wu): Implement CHECK similar to chrome for all the platforms.

- // Then replace this with a CHECK(retval == KERN_SUCCESS);

+ // TODO(wu): Implement RTC_CHECK for all the platforms. Then replace this

+ // with a RTC_CHECK_EQ(retval, KERN_SUCCESS);

#ifndef WEBRTC_IOS

asm("int3");

#else

« no previous file with comments | « webrtc/system_wrappers/source/thread_win.cc ('k') | webrtc/test/frame_generator.cc » ('j') | no next file with comments »