webrtc/system_wrappers/source/critical_section_posix.cc - Issue 1335923002: Add RTC_ prefix to (D)CHECKs and related macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/critical_section_posix.cc

Issue 1335923002: Add RTC_ prefix to (D)CHECKs and related macros. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/system_wrappers/source/critical_section_posix.cc

diff --git a/webrtc/system_wrappers/source/critical_section_posix.cc b/webrtc/system_wrappers/source/critical_section_posix.cc

index 36b9f137351869758d0967e3cdb9e722015ddb12..41b77327a38328fd379b66a1c0a9d028549e4b97 100644

--- a/webrtc/system_wrappers/source/critical_section_posix.cc

+++ b/webrtc/system_wrappers/source/critical_section_posix.cc

@@ -10,8 +10,7 @@

// General note: return values for the various pthread synchronization APIs

// are explicitly ignored here. In Chromium, the same thing is done for release.

-// However, in debugging, failure in these APIs are logged. There is currently

-// no equivalent to DCHECK_EQ in WebRTC code so this is the best we can do here.

+// However, in debugging, failure in these APIs are logged.

// TODO(henrike): add logging when pthread synchronization APIs are failing.

#include "webrtc/system_wrappers/source/critical_section_posix.h"

« no previous file with comments | « webrtc/system_wrappers/interface/scoped_vector.h ('k') | webrtc/system_wrappers/source/event_timer_posix.cc » ('j') | no next file with comments »