Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Unified Diff: webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc

Issue 1335353005: Remove channel ids from various interfaces. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: LoopBackTransport SSRC demuxing. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc b/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
index 0dc33227711f62c219ee9d9b50ed4bf6262d36f3..bf53469a289a32319611b2bb20b3082d0e8e6a0e 100644
--- a/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
@@ -26,7 +26,6 @@
using namespace webrtc;
const int kVideoNackListSize = 30;
-const int kTestId = 123;
const uint32_t kTestSsrc = 3456;
const uint16_t kTestSequenceNumber = 2345;
const uint32_t kTestNumberOfPackets = 1350;
@@ -57,7 +56,7 @@ class TestRtpFeedback : public NullRtpFeedback {
TestRtpFeedback(RtpRtcp* rtp_rtcp) : rtp_rtcp_(rtp_rtcp) {}
virtual ~TestRtpFeedback() {}
- void OnIncomingSSRCChanged(const int32_t id, const uint32_t ssrc) override {
+ void OnIncomingSSRCChanged(const uint32_t ssrc) override {
rtp_rtcp_->SetRemoteSSRC(ssrc);
}
@@ -96,7 +95,7 @@ class RtxLoopBackTransport : public webrtc::Transport {
packet_loss_ = 0;
}
- int SendPacket(int channel, const void* data, size_t len) override {
+ int SendPacket(const void* data, size_t len) override {
count_++;
const unsigned char* ptr = static_cast<const unsigned char*>(data);
uint32_t ssrc = (ptr[8] << 24) + (ptr[9] << 16) + (ptr[10] << 8) + ptr[11];
@@ -150,7 +149,7 @@ class RtxLoopBackTransport : public webrtc::Transport {
return static_cast<int>(len);
}
- int SendRTCPPacket(int channel, const void* data, size_t len) override {
+ int SendRTCPPacket(const void* data, size_t len) override {
if (module_->IncomingRtcpPacket((const uint8_t*)data, len) == 0) {
return static_cast<int>(len);
}
@@ -181,7 +180,6 @@ class RtpRtcpRtxNackTest : public ::testing::Test {
void SetUp() override {
RtpRtcp::Configuration configuration;
- configuration.id = kTestId;
configuration.audio = false;
configuration.clock = &fake_clock;
receive_statistics_.reset(ReceiveStatistics::Create(&fake_clock));
@@ -192,7 +190,7 @@ class RtpRtcpRtxNackTest : public ::testing::Test {
rtp_feedback_.reset(new TestRtpFeedback(rtp_rtcp_module_));
rtp_receiver_.reset(RtpReceiver::CreateVideoReceiver(
- kTestId, &fake_clock, &receiver_, rtp_feedback_.get(),
+ &fake_clock, &receiver_, rtp_feedback_.get(),
&rtp_payload_registry_));
rtp_rtcp_module_->SetSSRC(kTestSsrc);

Powered by Google App Engine
This is Rietveld 408576698