Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1334793003: Remove VideoMediaChannel::SetRender(). (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoMediaChannel::SetRender(). Was a no-op in current implementation. BUG= R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/34fbfff068bf46d27812fb8fd531aea889a5feaf

Patch Set 1 #

Patch Set 2 : Remove fake SetRender #

Total comments: 2

Patch Set 3 : fix tests #

Patch Set 4 : bah, missed some expects #

Patch Set 5 : remove IsReadyToReceive from logging #

Total comments: 2

Patch Set 6 : {}s, woooooo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -78 lines) Patch
M talk/media/base/fakemediaengine.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/base/videoengine_unittest.h View 1 2 20 chunks +0 lines, -20 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvideoengine2.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M talk/media/webrtc/webrtcvideoengine2_unittest.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M talk/session/media/channel.cc View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 1 2 3 4 5 13 chunks +83 lines, -30 lines 0 comments Download

Messages

Total messages: 25 (5 generated)
pbos-webrtc
Hola, may I remove this chunk? :)
5 years, 3 months ago (2015-09-10 17:47:51 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334793003/1
5 years, 3 months ago (2015-09-10 17:48:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/9616)
5 years, 3 months ago (2015-09-10 17:56:27 UTC) #5
pbos-webrtc
+cc solenberg because this requires refactoring of tests or removing VoiceMediaChannel::SetPlayout (which would be preferable).
5 years, 3 months ago (2015-09-11 09:22:30 UTC) #6
pbos-webrtc
Remove fake SetRender
5 years, 3 months ago (2015-09-11 09:23:13 UTC) #7
pthatcher1
lgtm https://codereview.webrtc.org/1334793003/diff/20001/talk/session/media/channel.cc File talk/session/media/channel.cc (left): https://codereview.webrtc.org/1334793003/diff/20001/talk/session/media/channel.cc#oldcode1719 talk/session/media/channel.cc:1719: bool recv = IsReadyToReceive(); Might as well remove ...
5 years, 3 months ago (2015-09-16 22:18:22 UTC) #8
the sun
On 2015/09/11 09:22:30, pbos-webrtc wrote: > +cc solenberg because this requires refactoring of tests or ...
5 years, 3 months ago (2015-09-17 14:17:21 UTC) #9
pbos-webrtc
On 2015/09/17 14:17:21, the sun wrote: > On 2015/09/11 09:22:30, pbos-webrtc wrote: > > +cc ...
5 years, 3 months ago (2015-09-18 13:59:15 UTC) #10
pbos-webrtc
fix tests
5 years, 3 months ago (2015-09-24 16:35:48 UTC) #11
pbos-webrtc
bah, missed some expects
5 years, 3 months ago (2015-09-24 16:42:26 UTC) #12
pbos-webrtc
remove IsReadyToReceive from logging
5 years, 3 months ago (2015-09-24 16:44:26 UTC) #13
pbos-webrtc
PTAL, I had to fix the tests as best I knew. https://codereview.webrtc.org/1334793003/diff/20001/talk/session/media/channel.cc File talk/session/media/channel.cc (left): ...
5 years, 3 months ago (2015-09-24 16:44:38 UTC) #14
pthatcher1
https://codereview.webrtc.org/1334793003/diff/80001/talk/session/media/channel_unittest.cc File talk/session/media/channel_unittest.cc (right): https://codereview.webrtc.org/1334793003/diff/80001/talk/session/media/channel_unittest.cc#newcode494 talk/session/media/channel_unittest.cc:494: if (verify_playout_) {}s
5 years, 3 months ago (2015-09-24 16:46:53 UTC) #15
pbos-webrtc
{}s, woooooo
5 years, 3 months ago (2015-09-24 16:53:22 UTC) #16
pbos-webrtc
PTAL :D https://codereview.webrtc.org/1334793003/diff/80001/talk/session/media/channel_unittest.cc File talk/session/media/channel_unittest.cc (right): https://codereview.webrtc.org/1334793003/diff/80001/talk/session/media/channel_unittest.cc#newcode494 talk/session/media/channel_unittest.cc:494: if (verify_playout_) On 2015/09/24 16:46:52, pthatcher1 wrote: ...
5 years, 3 months ago (2015-09-24 16:53:45 UTC) #17
pthatcher1
lgtm
5 years, 3 months ago (2015-09-24 17:01:08 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334793003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334793003/100001
5 years, 3 months ago (2015-09-24 17:01:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334793003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334793003/100001
5 years, 3 months ago (2015-09-24 17:01:48 UTC) #23
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/34fbfff068bf46d27812fb8fd531aea889a5feaf Cr-Commit-Position: refs/heads/master@{#10059}
5 years, 3 months ago (2015-09-24 17:20:45 UTC) #24
pbos-webrtc
5 years, 3 months ago (2015-09-24 17:20:49 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
34fbfff068bf46d27812fb8fd531aea889a5feaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698