Add an option to avoid Java video track release when peer connection is closed.

Add an option to avoid Java video track release when peer connection is closed.

Currently disposing Java peer connection object will result in auto
release of media streams and media tracks added to peer connection.
Add an option to allow application to own video track so it can be
kept after peer connection is destroyed.

R=jiayl@webrtc.org, wzh@webrtc.org

Committed: https://crrev.com/32b5d231775c7862da74bd817ab00a54bb85a9b8
Cr-Commit-Position: refs/heads/master@{#9946}

[AlexG, 2015-09-11 16:54:54]

glaznev@webrtc.org changed reviewers:
+ wzh@webrtc.org

[AlexG, 2015-09-11 16:54:55]

PTAL

[AlexG, 2015-09-11 16:55:52]

The CQ bit was checked by glaznev@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-11 16:55:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1333363002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1333363002/1

[commit-bot: I haz the power, 2015-09-11 17:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 17:42:12]

Dry run: This issue passed the CQ dry run.

[AlexG, 2015-09-14 20:15:20]

glaznev@webrtc.org changed reviewers:
+ jiayl@webrtc.org

[AlexG, 2015-09-15 00:10:23]

PTAL.

[wzh, 2015-09-15 00:13:30]

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/VideoTrack.java (right):

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/VideoTrack.java:46: public boolean
preservedTrack() {
i think set/get or put/get are easier to read. Those two method names are too
similar and easily get called improperly.

[jiayl2, 2015-09-15 00:14:38]

lgtm

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/VideoTrack.java (right):

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/VideoTrack.java:42: public void
preserveTrack() {
please comment on these methods to explain what it does

[jiayl2, 2015-09-15 00:14:50]

not lgtm, clicked the wrong button

[AlexG, 2015-09-15 00:37:18]

PTAL

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
File talk/app/webrtc/java/src/org/webrtc/VideoTrack.java (right):

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/VideoTrack.java:42: public void
preserveTrack() {
On 2015/09/15 00:14:38, jiayl2 wrote:
> please comment on these methods to explain what it does

Done. Moved comment to MediaStream.

https://codereview.webrtc.org/1333363002/diff/1/talk/app/webrtc/java/src/org/...
talk/app/webrtc/java/src/org/webrtc/VideoTrack.java:46: public boolean
preservedTrack() {
On 2015/09/15 00:13:30, wzh wrote:
> i think set/get or put/get are easier to read. Those two method names are too
> similar and easily get called improperly.

Done. Did track preservation a little differently - this is basically not
property of track, but the way track is added to media stream. So I move all
logic to MediaStream from here.

[jiayl2, 2015-09-15 16:30:07]

lgtm

[AlexG, 2015-09-15 16:43:15]

The CQ bit was checked by glaznev@webrtc.org

[commit-bot: I haz the power, 2015-09-15 16:43:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1333363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1333363002/20001

[wzh, 2015-09-15 16:55:46]

lgtm

[AlexG, 2015-09-15 18:09:48]

Committed patchset #2 (id:20001) manually as
32b5d231775c7862da74bd817ab00a54bb85a9b8 (presubmit successful).

[commit-bot: I haz the power, 2015-09-15 18:09:54]

Patchset 2 (id:??) landed as
https://crrev.com/32b5d231775c7862da74bd817ab00a54bb85a9b8
Cr-Commit-Position: refs/heads/master@{#9946}