Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1332383002: Rename CaptureThread to EncodingThread. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename CaptureThread to EncodingThread. Gives a less confusing name, this thread is used to pick up captured frames and encode them. BUG= R=mflodman@webrtc.org Committed: https://crrev.com/7317248ea7a052c19393bbfa2bec22c78a639c94 Cr-Commit-Position: refs/heads/master@{#10010}

Patch Set 1 #

Total comments: 4

Patch Set 2 : EncoderThreadFunction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M webrtc/video/video_capture_input.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/video/video_capture_input.cc View 1 4 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pbos-webrtc
PTAL, I think this is less confusing.
5 years, 3 months ago (2015-09-11 14:09:52 UTC) #1
mflodman
https://codereview.webrtc.org/1332383002/diff/1/webrtc/video/video_capture_input.cc File webrtc/video/video_capture_input.cc (right): https://codereview.webrtc.org/1332383002/diff/1/webrtc/video/video_capture_input.cc#newcode43 webrtc/video/video_capture_input.cc:43: encoder_thread_(ThreadWrapper::CreateThread(CaptureThreadFunction, Should also rename 'CaptureThreadFunction' to 'Encoder...'. https://codereview.webrtc.org/1332383002/diff/1/webrtc/video/video_capture_input.cc#newcode45 webrtc/video/video_capture_input.cc:45: ...
5 years, 3 months ago (2015-09-20 08:35:14 UTC) #2
pbos-webrtc
EncoderThreadFunction
5 years, 3 months ago (2015-09-21 15:05:14 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1332383002/diff/1/webrtc/video/video_capture_input.cc File webrtc/video/video_capture_input.cc (right): https://codereview.webrtc.org/1332383002/diff/1/webrtc/video/video_capture_input.cc#newcode43 webrtc/video/video_capture_input.cc:43: encoder_thread_(ThreadWrapper::CreateThread(CaptureThreadFunction, On 2015/09/20 08:35:14, mflodman wrote: > Should also ...
5 years, 3 months ago (2015-09-21 15:11:23 UTC) #4
mflodman
lgtm
5 years, 3 months ago (2015-09-22 04:24:40 UTC) #5
pbos-webrtc
Committed patchset #2 (id:20001) manually as 7317248ea7a052c19393bbfa2bec22c78a639c94 (presubmit successful).
5 years, 3 months ago (2015-09-22 09:14:34 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 09:14:35 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7317248ea7a052c19393bbfa2bec22c78a639c94
Cr-Commit-Position: refs/heads/master@{#10010}

Powered by Google App Engine
This is Rietveld 408576698