Disable base/logging.h stderr logs by default for webrtc/ tests.

Disable base/logging.h stderr logs by default for webrtc/ tests.

base/logging.h dumped to stderr by default in debug mode, but webrtc
"trace" (via system_wrappers/../logging.h) has that feature disabled by
default. This makes the two consistent.

Bonus: log the filename:line in base/logging.h, which exists in the
system_wrappers variant.

TEST=neteq_impl.cc logs (which use base/logging.h) no longer appear in
debug mode, unless --logs=true is passed. Filenames appear correctly.

Committed: https://crrev.com/88703d756af45380efbb77212201b3543141281a
Cr-Commit-Position: refs/heads/master@{#9868}

[Andrew MacDonald, 2015-09-05 05:32:17]

andrew@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[Andrew MacDonald, 2015-09-05 05:32:18]

https://codereview.webrtc.org/1331503002/diff/1/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1331503002/diff/1/webrtc/base/logging.cc#newcod...
webrtc/base/logging.cc:234: log_to_stderr_ = log_to_stderr;
My intuition is to protect this with the mutex, but the dbg_sev_ write on l.228
isn't. I'm going on faith that it's handled correctly; either both or neither
should be guarded.

[hlundin-webrtc, 2015-09-06 10:10:44]

Thanks! LGTM.

https://codereview.webrtc.org/1331503002/diff/1/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1331503002/diff/1/webrtc/base/logging.cc#newcod...
webrtc/base/logging.cc:234: log_to_stderr_ = log_to_stderr;
On 2015/09/05 05:32:18, Andrew MacDonald wrote:
> My intuition is to protect this with the mutex, but the dbg_sev_ write on
l.228
> isn't. I'm going on faith that it's handled correctly; either both or neither
> should be guarded.

Acknowledged.

[Andrew MacDonald, 2015-09-07 06:30:57]

The CQ bit was checked by andrew@webrtc.org

[commit-bot: I haz the power, 2015-09-07 06:31:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1331503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1331503002/1

[commit-bot: I haz the power, 2015-09-07 07:35:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-07 07:35:14]

Patchset 1 (id:??) landed as
https://crrev.com/88703d756af45380efbb77212201b3543141281a
Cr-Commit-Position: refs/heads/master@{#9868}