Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1331443003: Remove GetOutputScaling from VoiceMediaChannel. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove GetOutputScaling from VoiceMediaChannel. BUG=webrtc:4690 Committed: https://crrev.com/bb741b3afa23ec59c1948841f2de71f422245564 Cr-Commit-Position: refs/heads/master@{#9870}

Patch Set 1 #

Patch Set 2 : Add back tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -46 lines) Patch
M talk/app/webrtc/webrtcsession.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M talk/media/base/fakemediaengine.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/base/mediachannel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
5 years, 3 months ago (2015-09-04 15:41:17 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-04 22:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1331443003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1331443003/40001
5 years, 3 months ago (2015-09-07 10:20:57 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-07 10:56:42 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 10:56:55 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bb741b3afa23ec59c1948841f2de71f422245564
Cr-Commit-Position: refs/heads/master@{#9870}

Powered by Google App Engine
This is Rietveld 408576698