Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: webrtc/base/constructormagic.h

Issue 1330283002: Revert of Consolidate constructormagic macros with Chromium version and remove Chromium override. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « talk/app/webrtc/videosource.cc ('k') | webrtc/base/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/constructormagic.h
diff --git a/webrtc/base/constructormagic.h b/webrtc/base/constructormagic.h
index 6971580507c0b6475e31075fb419f434beac8fb7..6b1244fc6457e177f568d2a19c1e9e1f28502b00 100644
--- a/webrtc/base/constructormagic.h
+++ b/webrtc/base/constructormagic.h
@@ -14,27 +14,27 @@
// Undefine macros first, just in case. Some third-party includes have their own
// version.
-// Put this in the declarations for a class to be unassignable.
#undef DISALLOW_ASSIGN
#define DISALLOW_ASSIGN(TypeName) \
- void operator=(const TypeName&) = delete
+ void operator=(const TypeName&)
-// A macro to disallow the copy constructor and operator= functions. This should
-// be used in the declarations for a class.
+// A macro to disallow the evil copy constructor and operator= functions
+// This should be used in the private: declarations for a class.
#undef DISALLOW_COPY_AND_ASSIGN
-#define DISALLOW_COPY_AND_ASSIGN(TypeName) \
- TypeName(const TypeName&) = delete; \
+#define DISALLOW_COPY_AND_ASSIGN(TypeName) \
+ TypeName(const TypeName&); \
DISALLOW_ASSIGN(TypeName)
-// A macro to disallow all the implicit constructors, namely the default
-// constructor, copy constructor and operator= functions.
+// A macro to disallow all the implicit constructors, namely the
+// default constructor, copy constructor and operator= functions.
//
-// This should be used in the declarations for a class that wants to prevent
-// anyone from instantiating it. This is especially useful for classes
-// containing only static methods.
+// This should be used in the private: declarations for a class
+// that wants to prevent anyone from instantiating it. This is
+// especially useful for classes containing only static methods.
#undef DISALLOW_IMPLICIT_CONSTRUCTORS
#define DISALLOW_IMPLICIT_CONSTRUCTORS(TypeName) \
- TypeName() = delete; \
+ TypeName(); \
DISALLOW_COPY_AND_ASSIGN(TypeName)
+
#endif // WEBRTC_BASE_CONSTRUCTORMAGIC_H_
« no previous file with comments | « talk/app/webrtc/videosource.cc ('k') | webrtc/base/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698