talk/app/webrtc/webrtcsession_unittest.cc - Issue 1329493005: Provide RSA2048 as per RFC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1329493005: Provide RSA2048 as per RFC (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Allow full parameterization of RSA, curve id for ECDSA. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/webrtcsession_unittest.cc

diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc

index dbe485cdbfb2c27865fed002d54d6e6c16ceff7b..a0cd1563b097851fc817a3b1943c0daff72c05a3 100644

--- a/talk/app/webrtc/webrtcsession_unittest.cc

+++ b/talk/app/webrtc/webrtcsession_unittest.cc

@@ -596,8 +596,9 @@ class WebRtcSessionTest

rtc::ToString(rtc::CreateRandomId());

// Confirmed to work with KT_RSA and KT_ECDSA.

tdesc_factory_->set_certificate(rtc::RTCCertificate::Create(

- rtc::scoped_ptr<rtc::SSLIdentity>(rtc::SSLIdentity::Generate(

- identity_name, rtc::KT_DEFAULT)).Pass()));

+ rtc::scoped_ptr<rtc::SSLIdentity>(

+ rtc::SSLIdentity::Generate(identity_name, rtc::KeyTypeFull()))

hbos 2015/09/29 13:53:18 Here and other places: I prefer KeyTypeFull::Defau

torbjorng (webrtc) 2015/10/01 11:43:18 Done.

+ .Pass()));

tdesc_factory_->set_secure(cricket::SEC_REQUIRED);

}