Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328453003: Add more IceCandidatePairType for host-host CandidatePair (Closed)

Created:
5 years, 3 months ago by guoweis_webrtc
Modified:
5 years, 3 months ago
Reviewers:
pthatcher2, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add more IceCandidatePairType for host-host CandidatePair This is to help to differentiate endpoints which are behind NAT or on the public internet. BUG=520101 R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/3cc834ae8628ef042497d8effe4bd223235bcd28

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M talk/app/webrtc/umametrics.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 2 1 chunk +17 lines, -2 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
guoweis_webrtc
On 2015/09/04 03:19:54, guoweis wrote: > mailto:guoweis@webrtc.org changed reviewers: > + mailto:pthatcher@chromium.org PTAL.
5 years, 3 months ago (2015-09-04 03:30:47 UTC) #2
pthatcher1
lgtm
5 years, 3 months ago (2015-09-04 18:57:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328453003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328453003/60001
5 years, 3 months ago (2015-09-04 18:59:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328453003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328453003/60001
5 years, 3 months ago (2015-09-04 21:45:53 UTC) #9
guoweis_webrtc
5 years, 3 months ago (2015-09-04 23:00:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
3cc834ae8628ef042497d8effe4bd223235bcd28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698