webrtc/modules/video_coding/main/source/jitter_buffer.cc - Issue 1327933003: Enable probing with repeated payload packets by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/jitter_buffer.cc

Issue 1327933003: Enable probing with repeated payload packets by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixes a race with padding timestamps, and a flake in the nack test. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/rtp_rtcp/source/rtp_sender.cc ('K') | « webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc ('k') | webrtc/video/end_to_end_tests.cc » ('j') | webrtc/video/end_to_end_tests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/main/source/jitter_buffer.cc

diff --git a/webrtc/modules/video_coding/main/source/jitter_buffer.cc b/webrtc/modules/video_coding/main/source/jitter_buffer.cc

index 49c2325d80a852971edb1dff629b9c5a997e27e7..162b0246f0830a03fa0dbc6de29aa64bf3d44b2f 100644

--- a/webrtc/modules/video_coding/main/source/jitter_buffer.cc

+++ b/webrtc/modules/video_coding/main/source/jitter_buffer.cc

@@ -914,6 +914,8 @@ std::vector<uint16_t> VCMJitterBuffer::GetNackList(bool* request_key_frame) {

}

if (last_decoded_state_.in_initial_state()) {

VCMFrameBuffer* next_frame = NextFrame();

+ if (!next_frame)

+ return std::vector<uint16_t>();

const bool first_frame_is_key = next_frame &&

next_frame->FrameType() == kVideoFrameKey &&

next_frame->HaveFirstPacket();