Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.h

Issue 1327933003: Enable probing with repeated payload packets by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixes a race with padding timestamps, and a flake in the nack test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_sender.h
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender.h b/webrtc/modules/rtp_rtcp/source/rtp_sender.h
index 3b93ae40b69eb3925349b9596bc8064706b05aa4..8bfc94aeb28b10803ef42b9c7000191d81baf035 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender.h
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender.h
@@ -297,9 +297,10 @@ class RTPSender : public RTPSenderInterface {
int32_t SetFecParameters(const FecProtectionParams *delta_params,
const FecProtectionParams *key_params);
- size_t SendPadData(uint32_t timestamp,
- int64_t capture_time_ms,
- size_t bytes);
+ size_t SendPadData(size_t bytes,
+ bool timestamp_provided,
+ uint32_t timestamp,
+ int64_t capture_time_ms);
// Called on update of RTP statistics.
void RegisterRtpStatisticsCallback(StreamDataCountersCallback* callback);
@@ -341,9 +342,10 @@ class RTPSender : public RTPSenderInterface {
// Return the number of bytes sent. Note that both of these functions may
// return a larger value that their argument.
size_t TrySendRedundantPayloads(size_t bytes);
- size_t TrySendPadData(size_t bytes);
- size_t BuildPaddingPacket(uint8_t* packet, size_t header_length);
+ void BuildPaddingPacket(uint8_t* packet,
+ size_t header_length,
+ size_t padding_length);
void BuildRtxPacket(uint8_t* buffer, size_t* length,
uint8_t* buffer_rtx);

Powered by Google App Engine
This is Rietveld 408576698