Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc

Issue 1327933003: Enable probing with repeated payload packets by default. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing yet another flake in libjingle tests. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 // value sent. 313 // value sent.
314 // Here we are adding it to every packet of every frame at this point. 314 // Here we are adding it to every packet of every frame at this point.
315 if (!rtpHdr) { 315 if (!rtpHdr) {
316 DCHECK(!_rtpSender.IsRtpHeaderExtensionRegistered( 316 DCHECK(!_rtpSender.IsRtpHeaderExtensionRegistered(
317 kRtpExtensionVideoRotation)); 317 kRtpExtensionVideoRotation));
318 } else if (cvo_mode == RTPSenderInterface::kCVOActivated) { 318 } else if (cvo_mode == RTPSenderInterface::kCVOActivated) {
319 // Checking whether CVO header extension is registered will require taking 319 // Checking whether CVO header extension is registered will require taking
320 // a lock. It'll be a no-op if it's not registered. 320 // a lock. It'll be a no-op if it's not registered.
321 // TODO(guoweis): For now, all packets sent will carry the CVO such that 321 // TODO(guoweis): For now, all packets sent will carry the CVO such that
322 // the RTP header length is consistent, although the receiver side will 322 // the RTP header length is consistent, although the receiver side will
323 // only exam the packets with market bit set. 323 // only exam the packets with marker bit set.
324 size_t packetSize = payloadSize + rtp_header_length; 324 size_t packetSize = payloadSize + rtp_header_length;
325 RtpUtility::RtpHeaderParser rtp_parser(dataBuffer, packetSize); 325 RtpUtility::RtpHeaderParser rtp_parser(dataBuffer, packetSize);
326 RTPHeader rtp_header; 326 RTPHeader rtp_header;
327 rtp_parser.Parse(rtp_header); 327 rtp_parser.Parse(rtp_header);
328 _rtpSender.UpdateVideoRotation(dataBuffer, packetSize, rtp_header, 328 _rtpSender.UpdateVideoRotation(dataBuffer, packetSize, rtp_header,
329 rtpHdr->rotation); 329 rtpHdr->rotation);
330 } 330 }
331 if (fec_enabled) { 331 if (fec_enabled) {
332 SendVideoPacketAsRed(dataBuffer, payload_bytes_in_packet, 332 SendVideoPacketAsRed(dataBuffer, payload_bytes_in_packet,
333 rtp_header_length, _rtpSender.SequenceNumber(), 333 rtp_header_length, _rtpSender.SequenceNumber(),
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 CriticalSectionScoped cs(crit_.get()); 370 CriticalSectionScoped cs(crit_.get());
371 return _retransmissionSettings; 371 return _retransmissionSettings;
372 } 372 }
373 373
374 void RTPSenderVideo::SetSelectiveRetransmissions(uint8_t settings) { 374 void RTPSenderVideo::SetSelectiveRetransmissions(uint8_t settings) {
375 CriticalSectionScoped cs(crit_.get()); 375 CriticalSectionScoped cs(crit_.get());
376 _retransmissionSettings = settings; 376 _retransmissionSettings = settings;
377 } 377 }
378 378
379 } // namespace webrtc 379 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc ('k') | webrtc/video/end_to_end_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698