Full impl of NnChannel::SetSendParameters and NnChannel::SetRecvParameters

talk/media/base/fakemediaengine.h

 /*
  * libjingle
  * Copyright 2004 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 85 matching lines @@
     bool success = !rtcp_packets_.empty();
     if (success) {
       std::string packet = rtcp_packets_.front();
       rtcp_packets_.pop_front();
       success = (packet == std::string(static_cast<const char*>(data), len));
     }
     return success;
   }
   bool CheckNoRtp() { return rtp_packets_.empty(); }
   bool CheckNoRtcp() { return rtcp_packets_.empty(); }
-  virtual bool SetRecvRtpHeaderExtensions(
-      const std::vector<RtpHeaderExtension>& extensions) {
-    recv_extensions_ = extensions;
-    return true;
-  }
-  virtual bool SetSendRtpHeaderExtensions(
-      const std::vector<RtpHeaderExtension>& extensions) {
-    send_extensions_ = extensions;
-    return true;
-  }
   void set_fail_set_send_codecs(bool fail) { fail_set_send_codecs_ = fail; }
   void set_fail_set_recv_codecs(bool fail) { fail_set_recv_codecs_ = fail; }
   virtual bool AddSendStream(const StreamParams& sp) {
     if (std::find(send_streams_.begin(), send_streams_.end(), sp) !=
         send_streams_.end()) {
       return false;
     }
     send_streams_.push_back(sp);
     return true;
   }
   virtual bool RemoveSendStream(uint32 ssrc) {
     return RemoveStreamBySsrc(&send_streams_, ssrc);
   }
   virtual bool AddRecvStream(const StreamParams& sp) {
     if (std::find(receive_streams_.begin(), receive_streams_.end(), sp) !=
         receive_streams_.end()) {
       return false;
     }
     receive_streams_.push_back(sp);
     return true;
   }
   virtual bool RemoveRecvStream(uint32 ssrc) {
     return RemoveStreamBySsrc(&receive_streams_, ssrc);
   }
-  virtual bool MuteStream(uint32 ssrc, bool on) {
-    if (!HasSendStream(ssrc) && ssrc != 0)
-      return false;
-    if (on)
-      muted_streams_.insert(ssrc);
-    else
-      muted_streams_.erase(ssrc);
-    return true;
-  }
   bool IsStreamMuted(uint32 ssrc) const {
     bool ret = muted_streams_.find(ssrc) != muted_streams_.end();
     // If |ssrc = 0| check if the first send stream is muted.
     if (!ret && ssrc == 0 && !send_streams_.empty()) {
       return muted_streams_.find(send_streams_[0].first_ssrc()) !=
              muted_streams_.end();
     }
     return ret;
   }
   const std::vector<StreamParams>& send_streams() const {
@@ skipping 22 matching lines @@
     if (send_streams_.empty())
       return "";
     return send_streams_[0].cname;
   }
 
   bool ready_to_send() const {
     return ready_to_send_;
   }
 
  protected:
+  bool MuteStream(uint32 ssrc, bool mute) {
+    if (!HasSendStream(ssrc) && ssrc != 0) {
+      return false;
+    }
+    if (mute) {
+      muted_streams_.insert(ssrc);
+    } else {
+      muted_streams_.erase(ssrc);
+    }
+    return true;
+  }
   bool set_sending(bool send) {
     sending_ = send;
     return true;
   }
   void set_playout(bool playout) { playout_ = playout; }
+  bool SetRecvRtpHeaderExtensions(
+      const std::vector<RtpHeaderExtension>& extensions) {
+    recv_extensions_ = extensions;
+    return true;
+  }
+  bool SetSendRtpHeaderExtensions(
+      const std::vector<RtpHeaderExtension>& extensions) {
+    send_extensions_ = extensions;
+    return true;
+  }
   virtual void OnPacketReceived(rtc::Buffer* packet,
                                 const rtc::PacketTime& packet_time) {
     rtp_packets_.push_back(std::string(packet->data<char>(), packet->size()));
   }
   virtual void OnRtcpReceived(rtc::Buffer* packet,
                               const rtc::PacketTime& packet_time) {
     rtcp_packets_.push_back(std::string(packet->data<char>(), packet->size()));
   }
   virtual void OnReadyToSend(bool ready) {
     ready_to_send_ = ready;
@@ skipping 44 matching lines @@
   const std::vector<AudioCodec>& codecs() const { return send_codecs(); }
   const std::vector<DtmfInfo>& dtmf_info_queue() const {
     return dtmf_info_queue_;
   }
   const AudioOptions& options() const { return options_; }
 
   uint32 ringback_tone_ssrc() const { return ringback_tone_ssrc_; }
   bool ringback_tone_play() const { return ringback_tone_play_; }
   bool ringback_tone_loop() const { return ringback_tone_loop_; }
 
-  virtual bool SetRecvCodecs(const std::vector<AudioCodec>& codecs) {
-    if (fail_set_recv_codecs()) {
-      // Fake the failure in SetRecvCodecs.
-      return false;
-    }
-    recv_codecs_ = codecs;
-    return true;
+  virtual bool SetSendParameters(const AudioSendParameters& params) {
+    return (SetSendCodecs(params.codecs) &&
+            SetSendRtpHeaderExtensions(params.extensions) &&
+            SetMaxSendBandwidth(params.max_bandwidth_bps) &&
+            SetOptions(params.options));
   }
-  virtual bool SetSendCodecs(const std::vector<AudioCodec>& codecs) {
-    if (fail_set_send_codecs()) {
-      // Fake the failure in SetSendCodecs.
-      return false;
-    }
-    send_codecs_ = codecs;
-    return true;
+
+  virtual bool SetRecvParameters(const AudioRecvParameters& params) {
+    return (SetRecvCodecs(params.codecs) &&
+            SetRecvRtpHeaderExtensions(params.extensions));
   }
   virtual bool SetPlayout(bool playout) {
     set_playout(playout);
     return true;
   }
   virtual bool SetSend(SendFlags flag) {
     if (fail_set_send_) {
       return false;
     }
     return set_sending(flag != SEND_NOTHING);
   }
-  virtual bool SetMaxSendBandwidth(int bps) { return true; }
+  virtual bool MuteStream(uint32 ssrc, bool mute, const AudioOptions* options) {
+    bool result = RtpHelper<VoiceMediaChannel>::MuteStream(ssrc, mute);
+    if (result && !mute && options) {
+      return SetOptions(*options);
+    } else {
+      return result;
+    }
+  }
   virtual bool AddRecvStream(const StreamParams& sp) {
     if (!RtpHelper<VoiceMediaChannel>::AddRecvStream(sp))
       return false;
     output_scalings_[sp.first_ssrc()] = OutputScaling();
     return true;
   }
   virtual bool RemoveRecvStream(uint32 ssrc) {
     if (!RtpHelper<VoiceMediaChannel>::RemoveRecvStream(ssrc))
       return false;
     output_scalings_.erase(ssrc);
@@ skipping 101 matching lines @@
     *ssrc = 0;
     *error = fail_set_send_ ? VoiceMediaChannel::ERROR_REC_DEVICE_OPEN_FAILED
                             : VoiceMediaChannel::ERROR_NONE;
   }
 
   void set_fail_set_send(bool fail) { fail_set_send_ = fail; }
   void TriggerError(uint32 ssrc, VoiceMediaChannel::Error error) {
     VoiceMediaChannel::SignalMediaError(ssrc, error);
   }
 
-  virtual bool SetOptions(const AudioOptions& options) {
-    // Does a "merge" of current options and set options.
-    options_.SetAll(options);
-    return true;
-  }
   virtual bool GetOptions(AudioOptions* options) const {
     *options = options_;
     return true;
   }
 
  private:
   struct OutputScaling {
     OutputScaling() : left(1.0), right(1.0) {}
     double left, right;
   };
@@ skipping 16 matching lines @@
                 int sample_rate,
                 int number_of_channels,
                 size_t number_of_frames) override {}
     void OnClose() override { renderer_ = NULL; }
     AudioRenderer* renderer() const { return renderer_; }
 
    private:
     AudioRenderer* renderer_;
   };
 
+  bool SetRecvCodecs(const std::vector<AudioCodec>& codecs) {
+    if (fail_set_recv_codecs()) {
+      // Fake the failure in SetRecvCodecs.
+      return false;
+    }
+    recv_codecs_ = codecs;
+    return true;
+  }
+  bool SetSendCodecs(const std::vector<AudioCodec>& codecs) {
+    if (fail_set_send_codecs()) {
+      // Fake the failure in SetSendCodecs.
+      return false;
+    }
+    send_codecs_ = codecs;
+    return true;
+  }
+  bool SetMaxSendBandwidth(int bps) { return true; }
+  bool SetOptions(const AudioOptions& options) {
+    // Does a "merge" of current options and set options.
+    options_.SetAll(options);
+    return true;
+  }
 
   FakeVoiceEngine* engine_;
   std::vector<AudioCodec> recv_codecs_;
   std::vector<AudioCodec> send_codecs_;
   std::map<uint32, OutputScaling> output_scalings_;
   std::vector<DtmfInfo> dtmf_info_queue_;
   bool fail_set_send_;
   uint32 ringback_tone_ssrc_;
   bool ringback_tone_play_;
   bool ringback_tone_loop_;
@@ skipping 37 matching lines @@
     *format = send_formats_[ssrc];
     return true;
   }
   virtual bool SetSendStreamFormat(uint32 ssrc, const VideoFormat& format) {
     if (send_formats_.find(ssrc) == send_formats_.end()) {
       return false;
     }
     send_formats_[ssrc] = format;
     return true;
   }
+  virtual bool SetSendParameters(const VideoSendParameters& params) {
+    return (SetSendCodecs(params.codecs) &&
+            SetSendRtpHeaderExtensions(params.extensions) &&
+            SetMaxSendBandwidth(params.max_bandwidth_bps) &&
+            SetOptions(params.options));
+  }
 
+  virtual bool SetRecvParameters(const VideoRecvParameters& params) {
+    return (SetRecvCodecs(params.codecs) &&
+            SetRecvRtpHeaderExtensions(params.extensions));
+  }
   virtual bool AddSendStream(const StreamParams& sp) {
     if (!RtpHelper<VideoMediaChannel>::AddSendStream(sp)) {
       return false;
     }
     SetSendStreamDefaultFormat(sp.first_ssrc());
     return true;
   }
   virtual bool RemoveSendStream(uint32 ssrc) {
     send_formats_.erase(ssrc);
     return RtpHelper<VideoMediaChannel>::RemoveSendStream(ssrc);
   }
 
   void DetachVoiceChannel() override {}
-  virtual bool SetRecvCodecs(const std::vector<VideoCodec>& codecs) {
-    if (fail_set_recv_codecs()) {
-      // Fake the failure in SetRecvCodecs.
-      return false;
-    }
-    recv_codecs_ = codecs;
-    return true;
-  }
-  virtual bool SetSendCodecs(const std::vector<VideoCodec>& codecs) {
-    if (fail_set_send_codecs()) {
-      // Fake the failure in SetSendCodecs.
-      return false;
-    }
-    send_codecs_ = codecs;
-
-    for (std::vector<StreamParams>::const_iterator it = send_streams().begin();
-         it != send_streams().end(); ++it) {
-      SetSendStreamDefaultFormat(it->first_ssrc());
-    }
-    return true;
-  }
   virtual bool GetSendCodec(VideoCodec* send_codec) {
     if (send_codecs_.empty()) {
       return false;
     }
     *send_codec = send_codecs_[0];
     return true;
   }
   virtual bool SetRender(bool render) {
     set_playout(render);
     return true;
   }
   virtual bool SetRenderer(uint32 ssrc, VideoRenderer* r) {
     if (ssrc != 0 && renderers_.find(ssrc) == renderers_.end()) {
       return false;
     }
     if (ssrc != 0) {
       renderers_[ssrc] = r;
     }
     return true;
   }
 
   virtual bool SetSend(bool send) { return set_sending(send); }
+  virtual bool MuteStream(uint32 ssrc, bool mute, const VideoOptions* options) {
+    bool result = RtpHelper<VideoMediaChannel>::MuteStream(ssrc, mute);
+    if (result && !mute && options) {
+      return SetOptions(*options);
+    } else {
+      return result;
+    }
+  }
   virtual bool SetCapturer(uint32 ssrc, VideoCapturer* capturer) {
     capturers_[ssrc] = capturer;
     return true;
   }
   bool HasCapturer(uint32 ssrc) const {
     return capturers_.find(ssrc) != capturers_.end();
   }
-  virtual bool SetMaxSendBandwidth(int bps) {
-    max_bps_ = bps;
-    return true;
-  }
   virtual bool AddRecvStream(const StreamParams& sp) {
     if (!RtpHelper<VideoMediaChannel>::AddRecvStream(sp))
       return false;
     renderers_[sp.first_ssrc()] = NULL;
     return true;
   }
   virtual bool RemoveRecvStream(uint32 ssrc) {
     if (!RtpHelper<VideoMediaChannel>::RemoveRecvStream(ssrc))
       return false;
     renderers_.erase(ssrc);
     return true;
   }
 
   virtual bool GetStats(VideoMediaInfo* info) { return false; }
   virtual bool SendIntraFrame() {
     sent_intra_frame_ = true;
     return true;
   }
   virtual bool RequestIntraFrame() {
     requested_intra_frame_ = true;
     return true;
   }
-  virtual bool SetOptions(const VideoOptions& options) {
-    options_ = options;
-    return true;
-  }
   virtual bool GetOptions(VideoOptions* options) const {
     *options = options_;
     return true;
   }
   virtual void UpdateAspectRatio(int ratio_w, int ratio_h) {}
   void set_sent_intra_frame(bool v) { sent_intra_frame_ = v; }
   bool sent_intra_frame() const { return sent_intra_frame_; }
   void set_requested_intra_frame(bool v) { requested_intra_frame_ = v; }
   bool requested_intra_frame() const { return requested_intra_frame_; }
 
  private:
+  bool SetRecvCodecs(const std::vector<VideoCodec>& codecs) {
+    if (fail_set_recv_codecs()) {
+      // Fake the failure in SetRecvCodecs.
+      return false;
+    }
+    recv_codecs_ = codecs;
+    return true;
+  }
+  bool SetSendCodecs(const std::vector<VideoCodec>& codecs) {
+    if (fail_set_send_codecs()) {
+      // Fake the failure in SetSendCodecs.
+      return false;
+    }
+    send_codecs_ = codecs;
+
+    for (std::vector<StreamParams>::const_iterator it = send_streams().begin();
+         it != send_streams().end(); ++it) {
+      SetSendStreamDefaultFormat(it->first_ssrc());
+    }
+    return true;
+  }
+  bool SetOptions(const VideoOptions& options) {
+    options_ = options;
+    return true;
+  }
+  bool SetMaxSendBandwidth(int bps) {
+    max_bps_ = bps;
+    return true;
+  }
+
   // Be default, each send stream uses the first send codec format.
   void SetSendStreamDefaultFormat(uint32 ssrc) {
     if (!send_codecs_.empty()) {
       send_formats_[ssrc] = VideoFormat(
           send_codecs_[0].width, send_codecs_[0].height,
           cricket::VideoFormat::FpsToInterval(send_codecs_[0].framerate),
           cricket::FOURCC_I420);
     }
   }
 
@@ skipping 12 matching lines @@
 class FakeDataMediaChannel : public RtpHelper<DataMediaChannel> {
  public:
   explicit FakeDataMediaChannel(void* unused)
       : send_blocked_(false), max_bps_(-1) {}
   ~FakeDataMediaChannel() {}
   const std::vector<DataCodec>& recv_codecs() const { return recv_codecs_; }
   const std::vector<DataCodec>& send_codecs() const { return send_codecs_; }
   const std::vector<DataCodec>& codecs() const { return send_codecs(); }
   int max_bps() const { return max_bps_; }
 
-  virtual bool SetRecvCodecs(const std::vector<DataCodec>& codecs) {
-    if (fail_set_recv_codecs()) {
-      // Fake the failure in SetRecvCodecs.
-      return false;
-    }
-    recv_codecs_ = codecs;
-    return true;
+  virtual bool SetSendParameters(const DataSendParameters& params) {
+    return (SetSendCodecs(params.codecs) &&
+            SetMaxSendBandwidth(params.max_bandwidth_bps));
   }
-  virtual bool SetSendCodecs(const std::vector<DataCodec>& codecs) {
-    if (fail_set_send_codecs()) {
-      // Fake the failure in SetSendCodecs.
-      return false;
-    }
-    send_codecs_ = codecs;
-    return true;
+  virtual bool SetRecvParameters(const DataRecvParameters& params) {
+    return SetRecvCodecs(params.codecs);
   }
   virtual bool SetSend(bool send) { return set_sending(send); }
   virtual bool SetReceive(bool receive) {
     set_playout(receive);
     return true;
   }
-  virtual bool SetMaxSendBandwidth(int bps) {
-    max_bps_ = bps;
-    return true;
-  }
   virtual bool AddRecvStream(const StreamParams& sp) {
     if (!RtpHelper<DataMediaChannel>::AddRecvStream(sp))
       return false;
     return true;
   }
   virtual bool RemoveRecvStream(uint32 ssrc) {
     if (!RtpHelper<DataMediaChannel>::RemoveRecvStream(ssrc))
       return false;
     return true;
   }
@@ skipping 10 matching lines @@
       return true;
     }
   }
 
   SendDataParams last_sent_data_params() { return last_sent_data_params_; }
   std::string last_sent_data() { return last_sent_data_; }
   bool is_send_blocked() { return send_blocked_; }
   void set_send_blocked(bool blocked) { send_blocked_ = blocked; }
 
  private:
+  bool SetRecvCodecs(const std::vector<DataCodec>& codecs) {
+    if (fail_set_recv_codecs()) {
+      // Fake the failure in SetRecvCodecs.
+      return false;
+    }
+    recv_codecs_ = codecs;
+    return true;
+  }
+  bool SetSendCodecs(const std::vector<DataCodec>& codecs) {
+    if (fail_set_send_codecs()) {
+      // Fake the failure in SetSendCodecs.
+      return false;
+    }
+    send_codecs_ = codecs;
+    return true;
+  }
+  bool SetMaxSendBandwidth(int bps) {
+    max_bps_ = bps;
+    return true;
+  }
+
   std::vector<DataCodec> recv_codecs_;
   std::vector<DataCodec> send_codecs_;
   SendDataParams last_sent_data_params_;
   std::string last_sent_data_;
   bool send_blocked_;
   int max_bps_;
 };
 
 // A base class for all of the shared parts between FakeVoiceEngine
 // and FakeVideoEngine.
@@ skipping 54 matching lines @@
     options_changed_ = true;
     return true;
   }
 
   VoiceMediaChannel* CreateChannel(const AudioOptions& options) {
     if (fail_create_channel_) {
       return nullptr;
     }
 
     FakeVoiceMediaChannel* ch = new FakeVoiceMediaChannel(this);
-    ch->SetOptions(options);
+    // TODO(solenberg): !!!!!! SetParameters with only options?
+    // ch->SetOptions(options);

[pthatcher1, 2015/09/04 23:21:16]

The options don't matter until the other parameters are available as well.  So
the only thing going on here is that the parameters are remembered until later. 

[the sun, 2015/09/11 15:03:03]

Done.

     channels_.push_back(ch);
     return ch;
   }
   FakeVoiceMediaChannel* GetChannel(size_t index) {
     return (channels_.size() > index) ? channels_[index] : NULL;
   }
   void UnregisterChannel(VoiceMediaChannel* channel) {
     channels_.erase(std::find(channels_.begin(), channels_.end(), channel));
   }
 
@@ skipping 97 matching lines @@
     return default_encoder_config_;
   }
 
   VideoMediaChannel* CreateChannel(const VideoOptions& options,
                                    VoiceMediaChannel* channel) {
     if (fail_create_channel_) {
       return NULL;
     }
 
     FakeVideoMediaChannel* ch = new FakeVideoMediaChannel(this);
-    ch->SetOptions(options);
+    // TODO(solenberg): !!!!! SetParameters with only options?
+    // ch->SetOptions(options);
     channels_.push_back(ch);
     return ch;
   }
   FakeVideoMediaChannel* GetChannel(size_t index) {
     return (channels_.size() > index) ? channels_[index] : NULL;
   }
   void UnregisterChannel(VideoMediaChannel* channel) {
     channels_.erase(std::find(channels_.begin(), channels_.end(), channel));
   }
 
@@ skipping 151 matching lines @@
 
  private:
   std::vector<FakeDataMediaChannel*> channels_;
   std::vector<DataCodec> data_codecs_;
   DataChannelType last_channel_type_;
 };
 
 }  // namespace cricket
 
 #endif  // TALK_MEDIA_BASE_FAKEMEDIAENGINE_H_