Full impl of NnChannel::SetSendParameters and NnChannel::SetRecvParameters

talk/media/webrtc/webrtcvideoengine2.cc

 /*
  * libjingle
  * Copyright 2014 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 584 matching lines @@
   }
 
   return true;
 }
 
 WebRtcVideoChannel2* WebRtcVideoEngine2::CreateChannel(
     webrtc::Call* call,
     const VideoOptions& options) {
   RTC_DCHECK(initialized_);
   LOG(LS_INFO) << "CreateChannel. Options: " << options.ToString();
-  WebRtcVideoChannel2* channel = new WebRtcVideoChannel2(call, options,
+  return new WebRtcVideoChannel2(call, options, video_codecs_,
       external_encoder_factory_, external_decoder_factory_);
-  channel->SetRecvCodecs(video_codecs_);
-  return channel;
 }
 
 const std::vector<VideoCodec>& WebRtcVideoEngine2::codecs() const {
   return video_codecs_;
 }
 
 const std::vector<RtpHeaderExtension>&
 WebRtcVideoEngine2::rtp_header_extensions() const {
   return rtp_header_extensions_;
 }
@@ skipping 138 matching lines @@
 
     AddDefaultFeedbackParams(&codec);
     supported_codecs.push_back(codec);
   }
   return supported_codecs;
 }
 
 WebRtcVideoChannel2::WebRtcVideoChannel2(
     webrtc::Call* call,
     const VideoOptions& options,
+    const std::vector<VideoCodec>& recv_codecs,
     WebRtcVideoEncoderFactory* external_encoder_factory,
     WebRtcVideoDecoderFactory* external_decoder_factory)
     : call_(call),
       unsignalled_ssrc_handler_(&default_unsignalled_ssrc_handler_),
       external_encoder_factory_(external_encoder_factory),
       external_decoder_factory_(external_decoder_factory) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   SetDefaultOptions();
   options_.SetAll(options);
   options_.cpu_overuse_detection.Get(&signal_cpu_adaptation_);
   rtcp_receiver_report_ssrc_ = kDefaultRtcpReceiverReportSsrc;
   sending_ = false;
   default_send_ssrc_ = 0;
+  SetRecvCodecs(recv_codecs);
 }
 
 void WebRtcVideoChannel2::SetDefaultOptions() {
   options_.cpu_overuse_detection.Set(true);
   options_.dscp.Set(false);
   options_.suspend_below_min_bitrate.Set(false);
   options_.video_noise_reduction.Set(true);
   options_.screencast_min_bitrate.Set(0);
 }
 
@@ skipping 777 matching lines @@
 // raise bitrates above the 2000k default bitrate cap.
 bool WebRtcVideoChannel2::SetMaxSendBandwidth(int max_bitrate_bps) {
   // TODO(pbos): Figure out whether b=AS means max bitrate for this
   // WebRtcVideoChannel2 (in which case we're good), or per sender (SSRC), in
   // which case this should not set a Call::BitrateConfig but rather reconfigure
   // all senders.
   LOG(LS_INFO) << "SetMaxSendBandwidth: " << max_bitrate_bps << "bps.";
   if (max_bitrate_bps == bitrate_config_.max_bitrate_bps)
     return true;
 
-  if (max_bitrate_bps <= 0) {
+  if (max_bitrate_bps < 0) {
+    // Option not set.
+    return true;
+  }
+  if (max_bitrate_bps == 0) {
     // Unsetting max bitrate.
     max_bitrate_bps = -1;
   }
   bitrate_config_.start_bitrate_bps = -1;
   bitrate_config_.max_bitrate_bps = max_bitrate_bps;
   if (max_bitrate_bps > 0 &&
       bitrate_config_.min_bitrate_bps > max_bitrate_bps) {
     bitrate_config_.min_bitrate_bps = max_bitrate_bps;
   }
   call_->SetBitrateConfig(bitrate_config_);
@@ skipping 1153 matching lines @@
       video_codecs[i].rtx_payload_type = rtx_mapping[video_codecs[i].codec.id];
     }
   }
 
   return video_codecs;
 }
 
 }  // namespace cricket
 
 #endif  // HAVE_WEBRTC_VIDEO