Full impl of NnChannel::SetSendParameters and NnChannel::SetRecvParameters

talk/media/sctp/sctpdataengine.h

 /*
  * libjingle
  * Copyright 2012 Google Inc. and Robin Seggelmann
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 130 matching lines @@
   explicit SctpDataMediaChannel(rtc::Thread* thread);
   virtual ~SctpDataMediaChannel();
 
   // When SetSend is set to true, connects. When set to false, disconnects.
   // Calling: "SetSend(true); SetSend(false); SetSend(true);" will connect,
   // disconnect, and reconnect.
   virtual bool SetSend(bool send);
   // Unless SetReceive(true) is called, received packets will be discarded.
   virtual bool SetReceive(bool receive);
 
+  virtual bool SetSendParameters(const DataSendParameters& params);
+  virtual bool SetRecvParameters(const DataRecvParameters& params);
   virtual bool AddSendStream(const StreamParams& sp);
   virtual bool RemoveSendStream(uint32 ssrc);
   virtual bool AddRecvStream(const StreamParams& sp);
   virtual bool RemoveRecvStream(uint32 ssrc);
 
   // Called when Sctp gets data. The data may be a notification or data for
   // OnSctpInboundData. Called from the worker thread.
   virtual void OnMessage(rtc::Message* msg);
   // Send data down this channel (will be wrapped as SCTP packets then given to
   // sctp that will then post the network interface by OnMessage).
   // Returns true iff successful data somewhere on the send-queue/network.
   virtual bool SendData(const SendDataParams& params,
                         const rtc::Buffer& payload,
                         SendDataResult* result = NULL);
   // A packet is received from the network interface. Posted to OnMessage.
   virtual void OnPacketReceived(rtc::Buffer* packet,
                                 const rtc::PacketTime& packet_time);
 
   // Exposed to allow Post call from c-callbacks.
   rtc::Thread* worker_thread() const { return worker_thread_; }
 
-  // TODO(ldixon): add a DataOptions class to mediachannel.h
-  virtual bool SetOptions(int options) { return false; }
-
   // Many of these things are unused by SCTP, but are needed to fulfill
   // the MediaChannel interface.
-  // TODO(pthatcher): Cleanup MediaChannel interface, or at least
-  // don't try calling these and return false.  Right now, things
-  // don't work if we return false.
-  virtual bool SetMaxSendBandwidth(int bps) { return true; }
-  virtual bool SetRecvRtpHeaderExtensions(
-      const std::vector<RtpHeaderExtension>& extensions) { return true; }
-  virtual bool SetSendRtpHeaderExtensions(
-      const std::vector<RtpHeaderExtension>& extensions) { return true; }
-  virtual bool SetSendCodecs(const std::vector<DataCodec>& codecs);
-  virtual bool SetRecvCodecs(const std::vector<DataCodec>& codecs);
   virtual void OnRtcpReceived(rtc::Buffer* packet,
                               const rtc::PacketTime& packet_time) {}
   virtual void OnReadyToSend(bool ready) {}
 
   void OnSendThresholdCallback();
   // Helper for debugging.
   void set_debug_name(const std::string& debug_name) {
     debug_name_ = debug_name;
   }
   const std::string& debug_name() const { return debug_name_; }
   const struct socket* socket() const { return sock_; }
  private:
   sockaddr_conn GetSctpSockAddr(int port);
 
+  bool SetSendCodecs(const std::vector<DataCodec>& codecs);
+  bool SetRecvCodecs(const std::vector<DataCodec>& codecs);
+
   // Creates the socket and connects. Sets sending_ to true.
   bool Connect();
   // Closes the socket. Sets sending_ to false.
   void Disconnect();
 
   // Returns false when openning the socket failed; when successfull sets
   // sending_ to true
   bool OpenSctpSocket();
   // Sets sending_ to false and sock_ to NULL.
   void CloseSctpSocket();
@@ skipping 44 matching lines @@
   StreamSet queued_reset_streams_;
   StreamSet sent_reset_streams_;
 
   // A human-readable name for debugging messages.
   std::string debug_name_;
 };
 
 }  // namespace cricket
 
 #endif  // TALK_MEDIA_SCTP_SCTPDATAENGINE_H_