Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1327853002: GN: Fix compilation with NaCl toolchain (Closed)

Created:
5 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Fix compilation with NaCl toolchain BUG=512899 TBR=kjellander@webrtc.org Committed: https://crrev.com/4df08ff37459ee7c9d545c2574c1a84b5e968243 Cr-Commit-Position: refs/heads/master@{#9846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
Sergey Ulanov
5 years, 3 months ago (2015-09-02 20:05:38 UTC) #2
jiayl
lgtm
5 years, 3 months ago (2015-09-02 20:06:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327853002/1
5 years, 3 months ago (2015-09-02 20:09:11 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-02 20:09:13 UTC) #7
jiayl2
lgtm
5 years, 3 months ago (2015-09-02 20:17:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327853002/1
5 years, 3 months ago (2015-09-02 20:21:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/584)
5 years, 3 months ago (2015-09-02 20:23:38 UTC) #13
Sergey Ulanov
+kjellander@webrtc.org in TBR for webrtc/BUILD.gn
5 years, 3 months ago (2015-09-02 20:55:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327853002/1
5 years, 3 months ago (2015-09-02 20:55:54 UTC) #17
kjellander_webrtc
lgtm
5 years, 3 months ago (2015-09-02 20:59:38 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 21:22:44 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 21:22:57 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4df08ff37459ee7c9d545c2574c1a84b5e968243
Cr-Commit-Position: refs/heads/master@{#9846}

Powered by Google App Engine
This is Rietveld 408576698