Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1327023002: Remove arraysize.h gcc hack and Chromium override. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
Reviewers:
tommi, Andrew MacDonald
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove arraysize.h gcc hack and Chromium override. Part of work removing dependency on Chromium's base. BUG=468375 (in particular comment #37) Committed: https://crrev.com/3dfe5d3d41d7b2f7de594b383d23a328303f3436 Cr-Commit-Position: refs/heads/master@{#9880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M webrtc/base/arraysize.h View 1 chunk +1 line, -10 lines 0 comments Download
D webrtc/overrides/webrtc/base/arraysize.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Henrik Grunell WebRTC
I don't know the story behind this gcc hack, but Chromium doesn't have it anymore ...
5 years, 3 months ago (2015-09-07 10:34:01 UTC) #2
tommi
lgtm
5 years, 3 months ago (2015-09-07 11:53:37 UTC) #3
Andrew MacDonald
lgtm The overrides are moving to Chromium's third_party/webrtc_overrides, right?
5 years, 3 months ago (2015-09-07 22:27:55 UTC) #4
Henrik Grunell WebRTC
On 2015/09/07 22:27:55, Andrew MacDonald wrote: > lgtm > > The overrides are moving to ...
5 years, 3 months ago (2015-09-08 07:56:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1327023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1327023002/1
5 years, 3 months ago (2015-09-08 07:56:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 07:57:37 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 07:57:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dfe5d3d41d7b2f7de594b383d23a328303f3436
Cr-Commit-Position: refs/heads/master@{#9880}

Powered by Google App Engine
This is Rietveld 408576698