Issue 1326583002: Revert "Adding unittests to AudioConferenceMixer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1326583002: Revert "Adding unittests to AudioConferenceMixer." (Closed)

Created:
5 years, 3 months ago by minyue-webrtc

Modified:
5 years, 3 months ago

Reviewers:
hlundin-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

Revert "Adding unittests to AudioConferenceMixer." This reverts commit 22c2729607964aa38d6cb4e521994453b6a271c4. The revert was because vector(size_t n) needs copy-ctor. Note that it does not rely on the copy-ctor after C++11. TBR=henrik.lundin@webrtc.org, BUG= Committed: https://chromium.googlesource.com/external/webrtc/+/e551f12a41cd65f8aae1c62b90869506a0b69b18

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -167 lines)			Patch
	D	webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc	View		1 chunk	+0 lines, -165 lines	0 comments	Download
	M	webrtc/modules/modules.gyp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

minyue-webrtc

Committed patchset #1 (id:1) manually as e551f12a41cd65f8aae1c62b90869506a0b69b18 (presubmit successful).

5 years, 3 months ago (2015-09-01 07:54:55 UTC) #2

Andrew MacDonald

Minor request: include the reason for the revert in the CL description for interested parties.

5 years, 3 months ago (2015-09-01 15:51:36 UTC) #4

minyue-webrtc

5 years, 3 months ago (2015-09-01 16:21:29 UTC) #5

Message was sent while issue was closed.

On 2015/09/01 15:51:36, Andrew MacDonald wrote:
> Minor request: include the reason for the revert in the CL description for
> interested parties.

yes, added it. And please take a look at the reland also.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages